Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: tests/compiler/dart2js/mirrors_test.dart

Issue 10837097: Mirror test updated cf. API change (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/mirrors_test.dart
diff --git a/tests/compiler/dart2js/mirrors_test.dart b/tests/compiler/dart2js/mirrors_test.dart
index 96aa7e899d8c2594c49e8a1dd0075b41f72c81a9..76dcaa0759c177e8d03e14331033bfff6d9944b9 100644
--- a/tests/compiler/dart2js/mirrors_test.dart
+++ b/tests/compiler/dart2js/mirrors_test.dart
@@ -281,9 +281,7 @@ void testBaz(MirrorSystem system, LibraryMirror helperLibrary,
Expect.isFalse(barInterface.isDeclaration, "Interface type is declaration");
var barInterfaceTypeArguments = barInterface.typeArguments();
Expect.isNotNull(barInterfaceTypeArguments, "Type arguments are missing");
- // TODO(johnniwinther): Ensure type arguments on supertypes. Expected result
- // should have been 1:
- Expect.equals(0, barInterfaceTypeArguments.length,
+ Expect.equals(1, barInterfaceTypeArguments.length,
"Type arguments is empty");
Expect.throws(() => bazClass.typeArguments(),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698