Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 10837096: Handle chrome.dll.pdb properly when incremental_chrome_dll is set. (Closed)

Created:
8 years, 4 months ago by grt (UTC plus 2)
Modified:
8 years, 4 months ago
Reviewers:
gab
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Handle chrome.dll.pdb properly when incremental_chrome_dll is set. Also: - speed up re-copies the XP/xcopy case by skipping old files - clean up output for re-copies in the robocopy case by ignoring "extra" files NOTRY=true BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149912

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -20 lines) Patch
M tools/win/copy-installer.bat View 2 chunks +24 lines, -20 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
grt (UTC plus 2)
8 years, 4 months ago (2012-08-03 11:32:02 UTC) #1
gab
lgtm (one comment below) https://chromiumcodereview.appspot.com/10837096/diff/1/tools/win/copy-installer.bat File tools/win/copy-installer.bat (right): https://chromiumcodereview.appspot.com/10837096/diff/1/tools/win/copy-installer.bat#newcode110 tools/win/copy-installer.bat:110: robocopy "%FROM%" "%TO%" %TOCOPY% /J ...
8 years, 4 months ago (2012-08-03 18:16:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/10837096/1
8 years, 4 months ago (2012-08-03 20:29:21 UTC) #3
commit-bot: I haz the power
Failed to apply patch for tools/win/copy-installer.bat: While running patch -p1 --forward --force; patching file tools/win/copy-installer.bat ...
8 years, 4 months ago (2012-08-03 20:29:22 UTC) #4
grt (UTC plus 2)
8 years, 4 months ago (2012-08-03 20:30:14 UTC) #5
On 2012/08/03 18:16:49, gab wrote:
> I'm not clear on what /XX does, from http://ss64.org/viewtopic.php?id=1370 it
> doesn't seem to do much... (and the actual documentation is even more vague).

in this case, it only suppresses meaningless output ("clean up output for
re-copies in the robocopy case by ignoring "extra" files").

Powered by Google App Engine
This is Rietveld 408576698