Magnifier: Support wrapping the cursor between extended monitors

Magnifier: Support wrapping the cursor between extended monitors

This CL supports wrapping the cursor between primary and secondary monitors. The behavior is described at comment #1 of crbug.com/139766.

BUG=139766
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150163

[yoshiki, 2012-08-03 08:53:15]

zork: could you take a look?

[Zachary Kuznia, 2012-08-06 06:07:57]

lgtm

https://chromiumcodereview.appspot.com/10837092/diff/3001/ash/magnifier/magni...
File ash/magnifier/magnification_controller.cc (right):

https://chromiumcodereview.appspot.com/10837092/diff/3001/ash/magnifier/magni...
ash/magnifier/magnification_controller.cc:181: // Does noting if both the origin
and the scale are not changed.
nit:  s/noting/nothing/

[yoshiki, 2012-08-06 07:55:28]

Thanks!

[commit-bot: I haz the power, 2012-08-06 07:55:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/10837092/1002

[commit-bot: I haz the power, 2012-08-06 07:55:47]

Presubmit check for 10837092-1002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ash

[yoshiki, 2012-08-06 08:27:24]

sky: Could you take a look as a OWNER?

[sky, 2012-08-06 15:09:47]

http://codereview.chromium.org/10837092/diff/1002/ash/magnifier/magnification...
File ash/magnifier/magnification_controller.cc (right):

http://codereview.chromium.org/10837092/diff/1002/ash/magnifier/magnification...
ash/magnifier/magnification_controller.cc:34: void
ConvertsCoordinateFromScreenToRoot(aura::RootWindow* root_window,
I believe Yusuke is adding something similar here
http://codereview.chromium.org/10835047/ . Wait for it.

http://codereview.chromium.org/10837092/diff/1002/ash/magnifier/magnification...
ash/magnifier/magnification_controller.cc:356: float scale = GetScale();
Should this do nothing if new_root_window == root_window_?

[yoshiki, 2012-08-06 22:22:15]

sky: PTAL

http://codereview.chromium.org/10837092/diff/1002/ash/magnifier/magnification...
File ash/magnifier/magnification_controller.cc (right):

http://codereview.chromium.org/10837092/diff/1002/ash/magnifier/magnification...
ash/magnifier/magnification_controller.cc:34: void
ConvertsCoordinateFromScreenToRoot(aura::RootWindow* root_window,
Thank you for advice. This converts just to current root_window coordinate. So
I've found this can be removed.

On 2012/08/06 15:09:47, sky wrote:
> I believe Yusuke is adding something similar here
> http://codereview.chromium.org/10835047/ . Wait for it.

http://codereview.chromium.org/10837092/diff/1002/ash/magnifier/magnification...
ash/magnifier/magnification_controller.cc:356: float scale = GetScale();
On 2012/08/06 15:09:47, sky wrote:
> Should this do nothing if new_root_window == root_window_?

Done.

[sky, 2012-08-06 22:55:55]

LGTM