Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Side by Side Diff: chrome/browser/ui/gtk/location_bar_view_gtk.cc

Issue 10837090: Change return type of FaviconTabHelper::GetFavicon() to gfx::Image. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/gtk/location_bar_view_gtk.h" 5 #include "chrome/browser/ui/gtk/location_bar_view_gtk.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 797 matching lines...) Expand 10 before | Expand all | Expand 10 after
808 content::NotificationService::current()->Notify( 808 content::NotificationService::current()->Notify(
809 chrome::NOTIFICATION_ACCESSIBILITY_CONTROL_FOCUSED, 809 chrome::NOTIFICATION_ACCESSIBILITY_CONTROL_FOCUSED,
810 content::Source<Profile>(profile), 810 content::Source<Profile>(profile),
811 content::Details<AccessibilityTextBoxInfo>(&info)); 811 content::Details<AccessibilityTextBoxInfo>(&info));
812 812
813 // Update the keyword and search hint states. 813 // Update the keyword and search hint states.
814 OnChanged(); 814 OnChanged();
815 } 815 }
816 816
817 SkBitmap LocationBarViewGtk::GetFavicon() const { 817 SkBitmap LocationBarViewGtk::GetFavicon() const {
818 return GetTabContents()->favicon_tab_helper()->GetFavicon(); 818 return GetTabContents()->favicon_tab_helper()->GetFavicon().AsBitmap();
819 } 819 }
820 820
821 string16 LocationBarViewGtk::GetTitle() const { 821 string16 LocationBarViewGtk::GetTitle() const {
822 return GetWebContents()->GetTitle(); 822 return GetWebContents()->GetTitle();
823 } 823 }
824 824
825 InstantController* LocationBarViewGtk::GetInstant() { 825 InstantController* LocationBarViewGtk::GetInstant() {
826 return browser_->instant_controller()->instant(); 826 return browser_->instant_controller()->instant();
827 } 827 }
828 828
(...skipping 1222 matching lines...) Expand 10 before | Expand all | Expand 10 after
2051 } 2051 }
2052 2052
2053 void LocationBarViewGtk::PageActionViewGtk::InspectPopup( 2053 void LocationBarViewGtk::PageActionViewGtk::InspectPopup(
2054 ExtensionAction* action) { 2054 ExtensionAction* action) {
2055 ExtensionPopupGtk::Show( 2055 ExtensionPopupGtk::Show(
2056 action->GetPopupUrl(current_tab_id_), 2056 action->GetPopupUrl(current_tab_id_),
2057 owner_->browser_, 2057 owner_->browser_,
2058 event_box_.get(), 2058 event_box_.get(),
2059 ExtensionPopupGtk::SHOW_AND_INSPECT); 2059 ExtensionPopupGtk::SHOW_AND_INSPECT);
2060 } 2060 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc ('k') | chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698