Use low resolution wallpaper for small screens.

Use low resolution wallpapers for small screens


BUG=140336
TBR=jhawkins

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149915

[bshe, 2012-08-03 02:25:45]

+saintlou could you please take a look at it?
+sky for Owners: ash/*

[Emmanuel Saint-loubert-Bié, 2012-08-03 14:28:25]

just a couple of nits and a question

https://chromiumcodereview.appspot.com/10837089/diff/5001/ash/desktop_backgro...
File ash/desktop_background/desktop_background_controller.cc (right):

https://chromiumcodereview.appspot.com/10837089/diff/5001/ash/desktop_backgro...
ash/desktop_background/desktop_background_controller.cc:138: wallpaper_height <
root_window_size.height())
Does this test works for smaller images that are tiled (e.g the gradients) and
will always have a width smaller that the display??

https://chromiumcodereview.appspot.com/10837089/diff/5001/ash/desktop_backgro...
File ash/desktop_background/desktop_background_resources.cc (right):

https://chromiumcodereview.appspot.com/10837089/diff/5001/ash/desktop_backgro...
ash/desktop_background/desktop_background_resources.cc:302:
IDR_AURA_WALLPAPERS_5_GRADIENT0,
I had forgotten the exact scheme when we discussed all of this. So I think the
gradients will look a lot better if we have 2 kinds too, 800 tall and 1700 tall.
I can provide the assets later on. 
If you do this then please introduce new IDs (and in the grd you can point to
the same files for now.)

https://chromiumcodereview.appspot.com/10837089/diff/5001/ash/desktop_backgro...
File ash/desktop_background/desktop_background_resources.h (right):

https://chromiumcodereview.appspot.com/10837089/diff/5001/ash/desktop_backgro...
ash/desktop_background/desktop_background_resources.h:24: MEDIUM,
nit: since this is not used yet, maybe we should remove

[bshe, 2012-08-03 15:01:33]

thanks

https://chromiumcodereview.appspot.com/10837089/diff/5001/ash/desktop_backgro...
File ash/desktop_background/desktop_background_controller.cc (right):

https://chromiumcodereview.appspot.com/10837089/diff/5001/ash/desktop_backgro...
ash/desktop_background/desktop_background_controller.cc:138: wallpaper_height <
root_window_size.height())
Ahha. I overlooked that case. Also custom wallpaper was overlooked. Added them
to the test.

On 2012/08/03 14:28:26, Emmanuel Saint-loubert-Bié wrote:
> Does this test works for smaller images that are tiled (e.g the gradients) and
> will always have a width smaller that the display??

https://chromiumcodereview.appspot.com/10837089/diff/5001/ash/desktop_backgro...
File ash/desktop_background/desktop_background_resources.cc (right):

https://chromiumcodereview.appspot.com/10837089/diff/5001/ash/desktop_backgro...
ash/desktop_background/desktop_background_resources.cc:302:
IDR_AURA_WALLPAPERS_5_GRADIENT0,
On 2012/08/03 14:28:26, Emmanuel Saint-loubert-Bié wrote:
> I had forgotten the exact scheme when we discussed all of this. So I think the
> gradients will look a lot better if we have 2 kinds too, 800 tall and 1700
tall.
> I can provide the assets later on. 
> If you do this then please introduce new IDs (and in the grd you can point to
> the same files for now.)

Added new IDS. Will add folder to the gradient images after you landed the
assets.

https://chromiumcodereview.appspot.com/10837089/diff/5001/ash/desktop_backgro...
File ash/desktop_background/desktop_background_resources.h (right):

https://chromiumcodereview.appspot.com/10837089/diff/5001/ash/desktop_backgro...
ash/desktop_background/desktop_background_resources.h:24: MEDIUM,
On 2012/08/03 14:28:26, Emmanuel Saint-loubert-Bié wrote:
> nit: since this is not used yet, maybe we should remove

Done.

[Emmanuel Saint-loubert-Bié, 2012-08-03 18:11:23]

lgtm

[sky, 2012-08-03 18:16:15]

LGTM

https://chromiumcodereview.appspot.com/10837089/diff/1025/ash/desktop_backgro...
File ash/desktop_background/desktop_background_controller.cc (right):

https://chromiumcodereview.appspot.com/10837089/diff/1025/ash/desktop_backgro...
ash/desktop_background/desktop_background_controller.cc:94: int index_;
const on this and 96 if you can.

https://chromiumcodereview.appspot.com/10837089/diff/1025/ash/desktop_backgro...
File ash/desktop_background/desktop_background_controller.h (right):

https://chromiumcodereview.appspot.com/10837089/diff/1025/ash/desktop_backgro...
ash/desktop_background/desktop_background_controller.h:74: // wallpaper after
loaded.
Document what |force_reload| means.

[bshe, 2012-08-03 19:35:11]

Done.

Will wait for try bots result and dcommit. Thanks!

https://chromiumcodereview.appspot.com/10837089/diff/1025/ash/desktop_backgro...
File ash/desktop_background/desktop_background_controller.cc (right):

https://chromiumcodereview.appspot.com/10837089/diff/1025/ash/desktop_backgro...
ash/desktop_background/desktop_background_controller.cc:94: int index_;
On 2012/08/03 18:16:15, sky wrote:
> const on this and 96 if you can.

Done.

https://chromiumcodereview.appspot.com/10837089/diff/1025/ash/desktop_backgro...
File ash/desktop_background/desktop_background_controller.h (right):

https://chromiumcodereview.appspot.com/10837089/diff/1025/ash/desktop_backgro...
ash/desktop_background/desktop_background_controller.h:74: // wallpaper after
loaded.
On 2012/08/03 18:16:15, sky wrote:
> Document what |force_reload| means.

Done.

[commit-bot: I haz the power, 2012-08-03 20:07:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/10837089/10009

[commit-bot: I haz the power, 2012-08-03 20:27:55]

Try job failure for 10837089-10009 (retry) on win_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[oshima, 2012-08-06 03:37:29]

drive-by question

https://chromiumcodereview.appspot.com/10837089/diff/10009/ui/resources/ui_re...
File ui/resources/ui_resources.grd (right):

https://chromiumcodereview.appspot.com/10837089/diff/10009/ui/resources/ui_re...
ui/resources/ui_resources.grd:474: <include
name="IDR_AURA_WALLPAPERS_ROMAINGUY_0_SMALL"
file="aura/wallpapers/small/romainguy_0.jpg" type="BINDATA" />
given that there is better scaling algorithm, can't we simply scale down the
larger image instead of managing two?

This may also potentially increase the memory usage when you have displays with
different scale factors.