Change PluginInstance so it shuts down the NaCl Plugin when it uses the IPC PPAPI proxy.

Change PluginInstance so it shuts down the NaCl Plugin when it uses the IPC PPAPI proxy.
BUG=116317
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149885

[bbudge, 2012-08-02 22:03:19]

This seems to solve the shut down problem after we have switched to the
IPC-based proxy.

[dmichael (off chromium), 2012-08-03 02:42:05]

Heh, almost seems like cheating. Great shortcut for now.

lgtm

http://codereview.chromium.org/10837086/diff/1/webkit/plugins/ppapi/ppapi_plu...
File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right):

http://codereview.chromium.org/10837086/diff/1/webkit/plugins/ppapi/ppapi_plu...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:318:
nacl_plugin_instance_interface_(NULL),
nit: I don't usually explicitly initialize scoped_ptrs...  they construct to
NULL by default.

[commit-bot: I haz the power, 2012-08-03 16:01:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/10837086/6002

[bbudge, 2012-08-03 17:51:20]

http://codereview.chromium.org/10837086/diff/1/webkit/plugins/ppapi/ppapi_plu...
File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right):

http://codereview.chromium.org/10837086/diff/1/webkit/plugins/ppapi/ppapi_plu...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:318:
nacl_plugin_instance_interface_(NULL),
On 2012/08/03 02:42:05, dmichael wrote:
> nit: I don't usually explicitly initialize scoped_ptrs...  they construct to
> NULL by default.

Done.

[commit-bot: I haz the power, 2012-08-03 18:57:01]

Change committed as 149885