The updated (simplified) look of set-as-default dialog on Windows8.

The updated (simplified) look of set-as-default dialog on Windows8.


BUG=140357
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150365

[robertshield, 2012-08-03 21:11:04]

lgtm

[James Hawkins, 2012-08-03 22:51:44]

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
File chrome/browser/resources/set_as_default_browser.css (right):

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
chrome/browser/resources/set_as_default_browser.css:31: padding-top: 70pt;
pt?  We don't usually use pt, so can you use px instead?

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
chrome/browser/resources/set_as_default_browser.css:59: font-size: 28pt;
font-size needs to be relative, not absolute.

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
chrome/browser/resources/set_as_default_browser.css:70: font-size: 14pt;
Relative, not absolute.

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
chrome/browser/resources/set_as_default_browser.css:72: margin-bottom: 4.9em;
Any reason we're using em here and px elsewhere?

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
chrome/browser/resources/set_as_default_browser.css:149: .button-strip {
Is this the same button-strip class used in the options code?

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
chrome/browser/resources/set_as_default_browser.css:155: bottom: 23pt;
px

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
File chrome/browser/resources/set_as_default_browser.html (right):

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
chrome/browser/resources/set_as_default_browser.html:36: <img
src="chrome-logo-faded.png" alt="chrome logo"></img>
i18n

[motek., 2012-08-06 18:38:30]

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
File chrome/browser/resources/set_as_default_browser.css (right):

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
chrome/browser/resources/set_as_default_browser.css:31: padding-top: 70pt;
On 2012/08/03 22:51:44, James Hawkins wrote:
> pt?  We don't usually use pt, so can you use px instead?

Done.

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
chrome/browser/resources/set_as_default_browser.css:59: font-size: 28pt;
On 2012/08/03 22:51:44, James Hawkins wrote:
> font-size needs to be relative, not absolute.

Done.

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
chrome/browser/resources/set_as_default_browser.css:70: font-size: 14pt;
On 2012/08/03 22:51:44, James Hawkins wrote:
> Relative, not absolute.

Done.

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
chrome/browser/resources/set_as_default_browser.css:72: margin-bottom: 4.9em;
On 2012/08/03 22:51:44, James Hawkins wrote:
> Any reason we're using em here and px elsewhere?
Not really. I mean: there was a reason. I got a mock for the new look & feel
that was spec'd in a funny way and it was just more convenient for me to express
it as proportions, even though originally it was all pixels. It reduces itself
to pixels, so there it is...

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
chrome/browser/resources/set_as_default_browser.css:149: .button-strip {
On 2012/08/03 22:51:44, James Hawkins wrote:
> Is this the same button-strip class used in the options code?
No, it is a coincidence. I needed a container to hold buttons spaced and nicely
aligned. I used to had two buttons here, now there is just one now but I kept
the container since it simplifies attributes.

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
chrome/browser/resources/set_as_default_browser.css:155: bottom: 23pt;
On 2012/08/03 22:51:44, James Hawkins wrote:
> px

Done.

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
File chrome/browser/resources/set_as_default_browser.html (right):

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
chrome/browser/resources/set_as_default_browser.html:36: <img
src="chrome-logo-faded.png" alt="chrome logo"></img>
On 2012/08/03 22:51:44, James Hawkins wrote:
> i18n
I don't understand. Could you please point me to an example or elaborate. I
checked in src/chrome/browser/ and it seems that <img> tags do not have i18n
content.

[James Hawkins, 2012-08-06 20:26:09]

lgtm

[commit-bot: I haz the power, 2012-08-06 20:27:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/motek@chromium.org/10837084/8001

[James Hawkins, 2012-08-06 21:21:13]

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
File chrome/browser/resources/set_as_default_browser.html (right):

https://chromiumcodereview.appspot.com/10837084/diff/2001/chrome/browser/reso...
chrome/browser/resources/set_as_default_browser.html:36: <img
src="chrome-logo-faded.png" alt="chrome logo"></img>
On 2012/08/06 18:38:30, motek. wrote:
> On 2012/08/03 22:51:44, James Hawkins wrote:
> > i18n
> I don't understand. Could you please point me to an example or elaborate. I
> checked in src/chrome/browser/ and it seems that <img> tags do not have i18n
> content. 

<img src="chrome-logo-faded.png" i18n-values="alt:chromeLogoString"></img>

[commit-bot: I haz the power, 2012-08-06 22:15:57]

Try job failure for 10837084-8001 (retry) (retry) on win_rel for step
"runhooks".
It's a second try, previously, step "runhooks" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-06 23:19:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/motek@chromium.org/10837084/8001

[commit-bot: I haz the power, 2012-08-07 00:03:23]

Try job failure for 10837084-8001 (previous was lost) (retry) on win for step
"runhooks".
It's a second try, previously, step "runhooks" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[motek., 2012-08-07 14:50:14]

<img src="chrome-logo-faded.png" i18n-values="alt:chromeLogoString"></img>

Thank you. This is now done. PTAL?

Also, since CQ doesn't like new binaries, I had to split the bitmap into a
separate CL (10855025). I would appreciate if you could tap this one first.

Regards,

M.

[James Hawkins, 2012-08-07 15:08:45]

SLGTM

[commit-bot: I haz the power, 2012-08-07 16:00:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/motek@chromium.org/10837084/11005

[commit-bot: I haz the power, 2012-08-07 17:21:17]

Change committed as 150365