Issue 10837081: Revert 149692 - Create a LinuxSandbox class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10837081: Revert 149692 - Create a LinuxSandbox class. (Closed)

Created:
8 years, 4 months ago by mazda

Modified:
8 years, 4 months ago

Reviewers:
jln (very slow on Chromium)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, agl, jln+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 149692 - Create a LinuxSandbox class. r149692 broke ChromiumOS (tegra2) build. The LinuxSandbox class aims to become the central place for Linux sandboxing inside content/. For now, this refactors mostly code from the Zygote. BUG= NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10826093 TBR=jln@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149705

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+137 lines, -329 lines)			Patch
M	content/browser/renderer_host/render_sandbox_host_linux.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	content/common/OWNERS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/child_process_sandbox_support_impl_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/child_process_sandbox_support_impl_shm_linux.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/common/sandbox_init_linux.cc	View	3 chunks	+18 lines, -2 lines	0 comments	Download
D	content/common/sandbox_linux.h	View	1 chunk	+0 lines, -94 lines	0 comments	Download
D	content/common/sandbox_linux.cc	View	1 chunk	+0 lines, -181 lines	0 comments	Download
A +	content/common/sandbox_methods_linux.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	content/common/seccomp_sandbox.h	View	2 chunks	+24 lines, -0 lines	0 comments	Download
M	content/content_common.gypi	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	content/public/common/sandbox_linux.h	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	content/zygote/zygote_linux.h	View	3 chunks	+11 lines, -1 line	0 comments	Download
M	content/zygote/zygote_linux.cc	View	3 chunks	+17 lines, -5 lines	0 comments	Download
M	content/zygote/zygote_main_linux.cc	View	4 chunks	+55 lines, -14 lines	0 comments	Download
M	sandbox/linux/suid/client/setuid_sandbox_client.h	View	3 chunks	+1 line, -5 lines	0 comments	Download
M	sandbox/linux/suid/client/setuid_sandbox_client.cc	View	3 chunks	+2 lines, -11 lines	0 comments	Download
M	sandbox/linux/suid/client/setuid_sandbox_client_unittest.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages