Work-around Windows 8 bug causing print footers and headers to have incorrect size.

Work-around Windows 8 bug causing print footers and headers to have incorrect size.

This change causes the code to take a different HFONT creation path, which doesn't exhibit the issue.

BUG=139206
TEST=Launch print preview under Windows 8 (desktop mode is fine). Print headers and footers shouldn't have a ridiculously large font size.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150207

[Alexei Svitkine (slow), 2012-08-06 22:06:13]

abodenha: review
thestig: OWNERS

[Albert Bodenhamer, 2012-08-06 22:08:41]

lgtm

http://codereview.chromium.org/10837080/diff/4001/chrome/renderer/print_web_v...
File chrome/renderer/print_web_view_helper.cc (right):

http://codereview.chromium.org/10837080/diff/4001/chrome/renderer/print_web_v...
chrome/renderer/print_web_view_helper.cc:446: gfx::FontList font_list(
Perhaps a comment here explaining WHY we go to the trouble of building a font
list instead of just directly setting the font size?

[Alexei Svitkine (slow), 2012-08-06 22:12:02]

http://codereview.chromium.org/10837080/diff/4001/chrome/renderer/print_web_v...
File chrome/renderer/print_web_view_helper.cc (right):

http://codereview.chromium.org/10837080/diff/4001/chrome/renderer/print_web_v...
chrome/renderer/print_web_view_helper.cc:446: gfx::FontList font_list(
On 2012/08/06 22:08:41, Albert Bodenhamer wrote:
> Perhaps a comment here explaining WHY we go to the trouble of building a font
> list instead of just directly setting the font size?

Done.

[Lei Zhang, 2012-08-06 22:18:01]

LGTM, but please make sure this works on Windows 7 too.

[Alexei Svitkine (slow), 2012-08-06 22:31:09]

On 2012/08/06 22:18:01, Lei Zhang wrote:
> LGTM, but please make sure this works on Windows 7 too.

Just checked, still looks fine on Windows 7.

[commit-bot: I haz the power, 2012-08-06 22:33:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10837080/9002

[commit-bot: I haz the power, 2012-08-06 23:10:31]

Try job failure for 10837080-9002 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-08-06 23:13:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10837080/9002

[commit-bot: I haz the power, 2012-08-07 01:12:10]

Change committed as 150207