implement Serialize/Deserialize, so we can serialize pictures

skia/ext/SkFontHost_fontconfig.cpp

 /* libs/graphics/ports/SkFontHost_fontconfig.cpp
 **
 ** Copyright 2008, Google Inc.
 **
 ** Licensed under the Apache License, Version 2.0 (the "License");
 ** you may not use this file except in compliance with the License.
 ** You may obtain a copy of the License at
 **
 **     http://www.apache.org/licenses/LICENSE-2.0
 **
@@ skipping 13 matching lines @@
 // [1] http://fontconfig.org
 // -----------------------------------------------------------------------------
 
 #include <map>
 #include <string>
 
 #include <sys/mman.h>
 #include <sys/stat.h>
 #include <unistd.h>
 
+#include "../../src/ports/SkFontDescriptor.h"

[alokp, 2012/08/08 21:11:34]

Is this allowed by style guide?
you should replace this with third_party/skia/src/ports/SkFontDescriptor.h

 #include "SkFontHost.h"
 #include "SkStream.h"
 #include "SkFontHost_fontconfig_control.h"
 #include "SkFontHost_fontconfig_impl.h"
 #include "SkFontHost_fontconfig_direct.h"
 
 static FontConfigInterface* global_fc_impl = NULL;
 
 void SkiaFontConfigUseDirectImplementation() {
     if (global_fc_impl)
@@ skipping 159 matching lines @@
     return typeface;
 }
 
 // static
 SkTypeface* SkFontHost::CreateTypefaceFromFile(const char path[])
 {
     SkASSERT(!"SkFontHost::CreateTypefaceFromFile unimplemented");
     return NULL;
 }
 
-void SkFontHost::Serialize(const SkTypeface*, SkWStream*) {
-    SkASSERT(!"SkFontHost::Serialize unimplemented");
-}
-
-SkTypeface* SkFontHost::Deserialize(SkStream* stream) {
-    SkASSERT(!"SkFontHost::Deserialize unimplemented");
-    return NULL;
-}
-
-// static
 uint32_t SkFontHost::NextLogicalFont(SkFontID curr, SkFontID orig) {
-    // We don't handle font fallback, WebKit does.
+    // webkit handles fallbacks, we don't

[alokp, 2012/08/08 21:11:34]

unnecessary change.

     return 0;
 }
 
 ///////////////////////////////////////////////////////////////////////////////
+
+// Serialize, Deserialize need to be compatible across platforms, hence the use
+// of SkFontDescriptor.
+
+void SkFontHost::Serialize(const SkTypeface* face, SkWStream* stream) {
+    SkFontDescriptor desc(face->style());
+
+    std::string resolved_family_name;
+
+    const unsigned filefaceid = UniqueIdToFileFaceId(face->uniqueID());
+    if (GetFcImpl()->Match(&resolved_family_name, NULL,
+            true /* filefaceid valid */, filefaceid, "", NULL, 0, NULL, NULL))
+        desc.setFamilyName(resolved_family_name.c_str());
+    else
+        desc.setFamilyName("sans-serif");
+
+    // would also like other names (see SkFontDescriptor.h)
+
+    desc.serialize(stream);
+    
+    // by convention, we also write out the actual sfnt data, preceeded by
+    // a packed-length. For now we skip that, so we just write the zero.
+    stream->writePackedUInt(0);
+}
+
+SkTypeface* SkFontHost::Deserialize(SkStream* stream) {
+    SkFontDescriptor desc(stream);
+
+    // by convention, Serialize will have also written the actual sfnt data.
+    // for now, we just want to skip it.
+    size_t size = stream->readPackedUInt();
+    stream->skip(size);
+
+    return SkFontHost::CreateTypeface(NULL, desc.getFamilyName(),
+                                      desc.getStyle());
+}
+
+///////////////////////////////////////////////////////////////////////////////
 
 class SkFileDescriptorStream : public SkStream {
   public:
     SkFileDescriptorStream(int fd) {
         memory_ = NULL;
         offset_ = 0;
 
         // this ensures that if we fail in the constructor, we will safely
         // ignore all subsequent calls to read() because we will always trim
         // the requested size down to 0
@@ skipping 91 matching lines @@
         if (!path)
           return 1;
     }
 
     if (path)
         SkASSERT(!"SkFontHost::GetFileName does not support the font path "
                   "retrieval.");
 
     return 0;
 }