Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 10837074: Enable PromoResourceServiceTest (Closed)

Created:
8 years, 4 months ago by aruslan
Modified:
8 years, 4 months ago
Reviewers:
achuithb
CC:
chromium-reviews, nilesh
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Enable PromoResourceServiceTest Enable the PromoResourceService tests on Android testbots and make sure they don't fail due to incorrectly set time on the testbot devices. BUG=139642 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152204

Patch Set 1 #

Patch Set 2 : git pull rebase #

Patch Set 3 : Devices in the past are ok. #

Patch Set 4 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M build/android/gtest_filter/unit_tests_disabled View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service_unittest.cc View 1 2 3 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
aruslan
Please review
8 years, 4 months ago (2012-08-02 22:01:24 UTC) #1
nilesh
LGTM.
8 years, 4 months ago (2012-08-02 22:09:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/10837074/8001
8 years, 4 months ago (2012-08-03 20:00:04 UTC) #3
commit-bot: I haz the power
Presubmit check for 10837074-8001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-03 20:00:10 UTC) #4
aruslan
8 years, 4 months ago (2012-08-03 20:01:50 UTC) #5
achuithb
I don't understand the fix. Could you please update the description of this CL to ...
8 years, 4 months ago (2012-08-03 21:44:47 UTC) #6
achuithb
Also, please add a comment with the test why the start time needs to be ...
8 years, 4 months ago (2012-08-03 21:45:27 UTC) #7
aruslan
Added. Please take a look.
8 years, 4 months ago (2012-08-03 23:04:09 UTC) #8
achuithb
Thanks for adding the comments. lgtm
8 years, 4 months ago (2012-08-03 23:05:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/10837074/6003
8 years, 4 months ago (2012-08-06 17:06:05 UTC) #10
commit-bot: I haz the power
Try job failure for 10837074-6003 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 17:21:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/10837074/6003
8 years, 4 months ago (2012-08-06 21:51:33 UTC) #12
commit-bot: I haz the power
Try job failure for 10837074-6003 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 22:39:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/10837074/6003
8 years, 4 months ago (2012-08-17 19:59:46 UTC) #14
commit-bot: I haz the power
8 years, 4 months ago (2012-08-18 01:43:53 UTC) #15
Change committed as 152204

Powered by Google App Engine
This is Rietveld 408576698