Remove old isolate API and update all code in the repository to use

samples/dartcombat/player.dart

-// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /** A local player (API known to the main isolate when creating players). */
 interface Player default PlayerImpl {
 
   Player();
 
   final Future<SendPort> portToPlayer;
 
@@ skipping 14 matching lines @@
   /** shoot asynchronously. */
   Future<int> shoot(int x, int y);
 }
 
 
 /**
  * A default implementation for player that sends messages to an isolate, which
  * contains the actual player state.
  */
 class PlayerImpl implements Player {
-  final Future<SendPort> portToPlayer;

[Siggi Cherem (dart-lang), 2012/08/02 16:43:35]

another note - we tried to make spawnFunction return a port directly, but that
needs to be fixed, I added a bug for it (http://dartbug.com/4329)

[Mads Ager (google), 2012/08/03 05:51:35]

Thanks for filing that bug Siggi. Based on your comments in the bug report I
agree that we should go back to Future<SendPort> here.

+  final SendPort portToPlayer;
 
-  PlayerImpl() : portToPlayer = new PlayerState().spawn();
+  PlayerImpl() : portToPlayer = spawnFunction(spawnPlayer);

[Siggi Cherem (dart-lang), 2012/08/02 16:43:35]

FYI - this will break once dart2js bug is fixed, this should be
spawnFunctionInDOM (which doesn't exist yet, http://dartbug.com/3050)

[Mads Ager (google), 2012/08/03 05:51:35]

Thanks Siggi! I'll add a comment that the players need access to the DOM and
that something like spawnFunctionInDOM is needed.

I think I got this working as well as it did before these changes. However, the
game is not really working. It doesn't work at all in Dartium (because the
isolates don't have DOM access). With dart2js some of it is working, but the
'shooting' part is not really working.

 
   void setup(Window window, int player) {
-    portToPlayer.then((SendPort port) => port.call(
+    portToPlayer.call(
         { "action" : MessageIds.SETUP,
-          "args" : [player] }));
+          "args" : [player] });
   }
 
   void set enemy(SendPort portToEnemy) {
-    portToPlayer.then((port) => port.call(
+    portToPlayer.call(
         { "action" : MessageIds.SET_ENEMY,
-          "args" : [portToEnemy]}));
+          "args" : [portToEnemy]});
   }
 
   void set _portForTest(SendPort testPort) {
-    portToPlayer.then((port) => port.call(
+    portToPlayer.call(
         { "action" : MessageIds.SET_PORT_FOR_TEST,
-          "args" : [testPort]}));
+          "args" : [testPort]});
   }
 }
 
 /**
  * A default implementation for an enemy that sends messages to an isolate,
  * which contains the actual enemy state.
  */
 class EnemyImpl implements Enemy {
   SendPort portToEnemy;
 
@@ skipping 28 matching lines @@
 
   /** message indicating that the enemy is ready to play. */
   static final ENEMY_IS_READY = 3;
 
   /** message describing a shoot action. */
   static final SHOOT = 4;
 
   /** message to set up a test port, used to make tests non-flaky. */
   static final SET_PORT_FOR_TEST = 5;
 }