Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11239)

Unified Diff: chrome/test/data/extensions/api_test/executescript/callback/test.js

Issue 10837066: Fixing crash in V8ValueConverter. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: No getters Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/executescript/callback/test.js
diff --git a/chrome/test/data/extensions/api_test/executescript/callback/test.js b/chrome/test/data/extensions/api_test/executescript/callback/test.js
index 27a12c79dfdf9d6d68baa1eb26e938a3cb76ac1e..f29e3a6450f7f25ef1a9db22f96bbe0e40d83a48 100644
--- a/chrome/test/data/extensions/api_test/executescript/callback/test.js
+++ b/chrome/test/data/extensions/api_test/executescript/callback/test.js
@@ -88,8 +88,8 @@ chrome.test.getConfig(function(config) {
// Non-pure ojbects (like DOM nodes) will get converted as best they can.
function executeCallbackDOMObjShouldSucceed() {
- var scriptDetails = {}
- scriptDetails.code = 'var a = document.getElementById("testDiv"); a';
+ var scriptDetails = {};
+ scriptDetails.code = 'var a = document.getElementById("testDiv"); a;';
chrome.tabs.executeScript(tabId, scriptDetails, function(scriptVal) {
chrome.tabs.get(tabId, chrome.test.callbackPass(function(tab) {
// Test passes as long as the DOM node was converted in some form
@@ -148,6 +148,18 @@ chrome.test.getConfig(function(config) {
chrome.test.assertFalse(null == scriptVal[0]);
}));
});
+ },
+
+ function executeCallbackInputShouldSucceed() {
+ var scriptDetails = {};
+ scriptDetails.code = 'var a = document.getElementById("testInput"); a;';
+ chrome.tabs.executeScript(tabId, scriptDetails, function(scriptVal) {
+ chrome.tabs.get(tabId, chrome.test.callbackPass(function(tab) {
+ // Test passes as long as the input element was converted in some
+ // form and is not null
+ chrome.test.assertTrue(scriptVal[0] != null);
+ }));
+ });
}
]);
});
« no previous file with comments | « chrome/test/data/extensions/api_test/executescript/callback/test.html ('k') | content/renderer/v8_value_converter_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698