Fixing crash in V8ValueConverter.

chrome/test/data/extensions/api_test/executescript/callback/test.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var relativePath =
     '/files/extensions/api_test/executescript/callback/test.html';
 var testUrl = 'http://b.com:PORT' + relativePath;
 
 chrome.test.getConfig(function(config) {
   testUrl = testUrl.replace(/PORT/, config.testServer.port);
@@ skipping 70 matching lines @@
         var scriptDetails = {code: 'var obj = {"id": "foo", "bar": 9}; obj'};
         chrome.tabs.executeScript(tabId, scriptDetails, function(scriptVal) {
           chrome.tabs.get(tabId, chrome.test.callbackPass(function(tab) {
             chrome.test.assertEq({"id": "foo", "bar": 9}, scriptVal[0]);
           }));
         });
       },
 
       // Non-pure ojbects (like DOM nodes) will get converted as best they can.
       function executeCallbackDOMObjShouldSucceed() {
-        var scriptDetails = {}
-        scriptDetails.code = 'var a = document.getElementById("testDiv"); a';
+        var scriptDetails = {};
+        scriptDetails.code = 'var a = document.getElementById("testDiv"); a;';
         chrome.tabs.executeScript(tabId, scriptDetails, function(scriptVal) {
           chrome.tabs.get(tabId, chrome.test.callbackPass(function(tab) {
             // Test passes as long as the DOM node was converted in some form
             // and is not null
             chrome.test.assertTrue(scriptVal[0] != null);
           }));
         });
       },
 
       // All non-integer properties are droped.
@@ skipping 38 matching lines @@
 
       function executeCallbackWindowShouldSucceed() {
         var scriptDetails = {code: 'window;'};
         chrome.tabs.executeScript(tabId, scriptDetails, function(scriptVal) {
           chrome.tabs.get(tabId, chrome.test.callbackPass(function(tab) {
             // Test passes as long as the window was converted in some form and
             // is not null
             chrome.test.assertFalse(null == scriptVal[0]);
           }));
         });
+      },
+
+      function executeCallbackInputShouldSucceed() {
+        var scriptDetails = {};
+        scriptDetails.code = 'var a = document.getElementById("testInput"); a;';
+        chrome.tabs.executeScript(tabId, scriptDetails, function(scriptVal) {
+          chrome.tabs.get(tabId, chrome.test.callbackPass(function(tab) {
+            // Test passes as long as the input element was converted in some
+            // form and is not null
+            chrome.test.assertTrue(scriptVal[0] != null);

[not at google - send to devlin, 2012/08/02 18:59:41]

drive-by: should this be a V8UnitTest?

[eaugusti, 2012/08/02 19:44:53]

Yes, it should be. It is just hard because it is actually WebKit that is
registering the named callbacks that are causing the crash. So right now all I
have is a unittest that says "Don't try and convert named callbacks".

+          }));
+        });
       }
     ]);
   });
   chrome.tabs.create({ url: testUrl });
 
 });