Don't show host permission warnings for platform apps.

chrome/common/extensions/permissions/permission_set.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_PERMISSIONS_PERMISSION_SET_H_
 #define CHROME_COMMON_EXTENSIONS_PERMISSIONS_PERMISSION_SET_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 61 matching lines @@
   // require no permissions).
   // TODO(kalman): return scoped_ptr to avoid copying.
   std::set<std::string> GetAPIsWithAnyAccessAsStrings() const;
 
   // Returns whether this namespace has any functions which the extension has
   // permission to use.  For example, even though the extension may not have
   // the "tabs" permission, "tabs.create" requires no permissions so
   // HasAnyAPIPermission("tabs") will return true.
   bool HasAnyAccessToAPI(const std::string& api_name) const;
 
-  // Gets a list of the distinct hosts for displaying to the user.
-  // NOTE: do not use this for comparing permissions, since this disgards some
-  // information.
-  std::set<std::string> GetDistinctHostsForDisplay() const;
-
   // Gets the localized permission messages that represent this set.
-  PermissionMessages GetPermissionMessages() const;
+  // The set of permission messages varies by extension type, hence the
+  // |extension| parameter.
+  PermissionMessages GetPermissionMessages(const Extension* extension) const;
 
   // Gets the localized permission messages that represent this set (represented
-  // as strings).
-  std::vector<string16> GetWarningMessages() const;
+  // as strings). The set of permission messages varies by extension type,
+  // hence the |extension| parameter.
+  std::vector<string16> GetWarningMessages(const Extension* extension) const;
 
   // Returns true if this is an empty set (e.g., the default permission set).
   bool IsEmpty() const;
 
   // Returns true if the set has the specified API permission.
   bool HasAPIPermission(APIPermission::ID permission) const;
 
   // Returns true if the permissions in this set grant access to the specified
   // |function_name|.
   bool HasAccessToFunction(const std::string& function_name) const;
@@ skipping 23 matching lines @@
 
   const URLPatternSet& effective_hosts() const { return effective_hosts_; }
 
   const URLPatternSet& explicit_hosts() const { return explicit_hosts_; }
 
   const URLPatternSet& scriptable_hosts() const { return scriptable_hosts_; }
 
  private:
   FRIEND_TEST_ALL_PREFIXES(PermissionsTest, HasLessHostPrivilegesThan);
   FRIEND_TEST_ALL_PREFIXES(PermissionsTest, GetWarningMessages_AudioVideo);
+  FRIEND_TEST_ALL_PREFIXES(PermissionsTest, GetDistinctHostsForDisplay);
+  FRIEND_TEST_ALL_PREFIXES(PermissionsTest,
+                           GetDistinctHostsForDisplay_ComIsBestRcd);
+  FRIEND_TEST_ALL_PREFIXES(PermissionsTest,
+                           GetDistinctHostsForDisplay_NetIs2ndBestRcd);
+  FRIEND_TEST_ALL_PREFIXES(PermissionsTest,
+                           GetDistinctHostsForDisplay_OrgIs3rdBestRcd);
+  FRIEND_TEST_ALL_PREFIXES(PermissionsTest,
+                           GetDistinctHostsForDisplay_FirstInListIs4thBestRcd);
   friend class base::RefCountedThreadSafe<PermissionSet>;
 
   ~PermissionSet();
 
   static std::set<std::string> GetDistinctHosts(
       const URLPatternSet& host_patterns,
       bool include_rcd,
       bool exclude_file_scheme);
 
   // Initializes the set based on |extension|'s manifest data.
@@ skipping 11 matching lines @@
   // Returns true if |permissions| has an elevated API privilege level than
   // this set.
   bool HasLessAPIPrivilegesThan(
       const PermissionSet* permissions) const;
 
   // Returns true if |permissions| has more host permissions compared to this
   // set.
   bool HasLessHostPrivilegesThan(
       const PermissionSet* permissions) const;
 
+  // Gets a list of the distinct hosts for displaying to the user.
+  // NOTE: do not use this for comparing permissions, since this disgards some
+  // information.
+  std::set<std::string> GetDistinctHostsForDisplay() const;
+
   // The api list is used when deciding if an extension can access certain
   // extension APIs and features.
   APIPermissionSet apis_;
 
   // The list of hosts that can be accessed directly from the extension.
   // TODO(jstritar): Rename to "hosts_"?
   URLPatternSet explicit_hosts_;
 
   // The list of hosts that can be scripted by content scripts.
   // TODO(jstritar): Rename to "user_script_hosts_"?
   URLPatternSet scriptable_hosts_;
 
   // The list of hosts this effectively grants access to.
   URLPatternSet effective_hosts_;
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_COMMON_EXTENSIONS_PERMISSIONS_PERMISSION_SET_H_