content/common/gpu/media/h264_parser.cc - Issue 10837058: Make H264BitReader ignore trailing zero bytes and stop bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/h264_parser.cc

Issue 10837058: Make H264BitReader ignore trailing zero bytes and stop bit. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Address CR comments. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/media/h264_parser.cc

diff --git a/content/common/gpu/media/h264_parser.cc b/content/common/gpu/media/h264_parser.cc

index db4622f068dd694d9668bd2125ed8cb6ce89d9de..05a3a7c38975558834fe5fb190b9fbe96bb4bf45 100644

--- a/content/common/gpu/media/h264_parser.cc

+++ b/content/common/gpu/media/h264_parser.cc

@@ -724,8 +724,9 @@ H264Parser::Result H264Parser::ParsePPS(int* pps_id) {

READ_BOOL_OR_RETURN(&pps->constrained_intra_pred_flag);

READ_BOOL_OR_RETURN(&pps->redundant_pic_cnt_present_flag);

- if (br_.HasMoreRBSPData()) {

- READ_BOOL_OR_RETURN(&pps->transform_8x8_mode_flag);

+ int temp;

+ if (br_.ReadBits(1, &temp)) {

+ pps->transform_8x8_mode_flag = temp != 0;

Ami GONE FROM CHROMIUM 2012/08/02 19:49:48 !=0 unnecessary

xiaomings 2012/08/03 00:37:58 Done.

READ_BOOL_OR_RETURN(&pps->pic_scaling_matrix_present_flag);

if (pps->pic_scaling_matrix_present_flag) {