Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: content/common/gpu/media/h264_bit_reader_unittest.cc

Issue 10837058: Make H264BitReader ignore trailing zero bytes and stop bit. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix up comment. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/media/h264_bit_reader_unittest.cc
diff --git a/content/common/gpu/media/h264_bit_reader_unittest.cc b/content/common/gpu/media/h264_bit_reader_unittest.cc
index 73f36b0cbb8e76c33c6a6a703fbb13eec99d825e..e5388591a90949823b639f96872d74ec6557398d 100644
--- a/content/common/gpu/media/h264_bit_reader_unittest.cc
+++ b/content/common/gpu/media/h264_bit_reader_unittest.cc
@@ -18,27 +18,22 @@ TEST(H264BitReaderTest, ReadStreamWithoutEscapeAndTrailingZeroBytes) {
EXPECT_TRUE(reader.ReadBits(1, &dummy));
EXPECT_EQ(dummy, 0x00);
EXPECT_EQ(reader.NumBitsLeft(), 47);
- EXPECT_TRUE(reader.HasMoreRBSPData());
EXPECT_TRUE(reader.ReadBits(8, &dummy));
EXPECT_EQ(dummy, 0x02);
EXPECT_EQ(reader.NumBitsLeft(), 39);
- EXPECT_TRUE(reader.HasMoreRBSPData());
EXPECT_TRUE(reader.ReadBits(31, &dummy));
EXPECT_EQ(dummy, 0x23456789);
EXPECT_EQ(reader.NumBitsLeft(), 8);
- EXPECT_TRUE(reader.HasMoreRBSPData());
EXPECT_TRUE(reader.ReadBits(1, &dummy));
EXPECT_EQ(dummy, 1);
EXPECT_EQ(reader.NumBitsLeft(), 7);
- EXPECT_TRUE(reader.HasMoreRBSPData());
EXPECT_TRUE(reader.ReadBits(1, &dummy));
EXPECT_EQ(dummy, 0);
EXPECT_EQ(reader.NumBitsLeft(), 6);
- EXPECT_FALSE(reader.HasMoreRBSPData());
}
TEST(H264BitReaderTest, EmptyStream) {
@@ -57,12 +52,10 @@ TEST(H264BitReaderTest, SingleByteStream) {
EXPECT_TRUE(reader.Initialize(rbsp, sizeof(rbsp)));
EXPECT_EQ(reader.NumBitsLeft(), 8);
- EXPECT_TRUE(reader.HasMoreRBSPData());
EXPECT_TRUE(reader.ReadBits(4, &dummy));
EXPECT_EQ(dummy, 0x01);
EXPECT_EQ(reader.NumBitsLeft(), 4);
- EXPECT_FALSE(reader.HasMoreRBSPData());
}
TEST(H264BitReaderTest, StopBitOccupyFullByte) {
@@ -72,12 +65,10 @@ TEST(H264BitReaderTest, StopBitOccupyFullByte) {
EXPECT_TRUE(reader.Initialize(rbsp, sizeof(rbsp)));
EXPECT_EQ(reader.NumBitsLeft(), 16);
- EXPECT_TRUE(reader.HasMoreRBSPData());
EXPECT_TRUE(reader.ReadBits(8, &dummy));
EXPECT_EQ(dummy, 0xab);
EXPECT_EQ(reader.NumBitsLeft(), 8);
- EXPECT_FALSE(reader.HasMoreRBSPData());
}
TEST(H264BitReaderTest, ReadFailure) {
@@ -108,17 +99,14 @@ TEST(H264BitReaderTest, EscapeSequence) {
EXPECT_TRUE(reader.ReadBits(8, &dummy));
EXPECT_EQ(dummy, 0x00);
EXPECT_EQ(reader.NumBitsLeft(), 80);
- EXPECT_TRUE(reader.HasMoreRBSPData());
EXPECT_TRUE(reader.ReadBits(24, &dummy));
EXPECT_EQ(dummy, 0x00);
EXPECT_EQ(reader.NumBitsLeft(), 48);
- EXPECT_TRUE(reader.HasMoreRBSPData());
EXPECT_TRUE(reader.ReadBits(15, &dummy));
EXPECT_EQ(dummy, 0x01);
EXPECT_EQ(reader.NumBitsLeft(), 25);
- EXPECT_FALSE(reader.HasMoreRBSPData());
}
TEST(H264BitReaderTest, NonEscapeFollowedByStopBit) {
@@ -130,7 +118,6 @@ TEST(H264BitReaderTest, NonEscapeFollowedByStopBit) {
EXPECT_TRUE(reader.ReadBits(23, &dummy));
EXPECT_EQ(dummy, 0x03);
EXPECT_EQ(reader.NumBitsLeft(), 33);
- EXPECT_FALSE(reader.HasMoreRBSPData());
}
TEST(H264BitReaderTest, TrailingZero) {
@@ -141,8 +128,6 @@ TEST(H264BitReaderTest, TrailingZero) {
EXPECT_TRUE(reader.Initialize(rbsp, sizeof(rbsp)));
EXPECT_TRUE(reader.ReadBits(8, &dummy));
EXPECT_EQ(dummy, 0x01);
- EXPECT_TRUE(reader.HasMoreRBSPData());
EXPECT_TRUE(reader.ReadBits(15, &dummy));
EXPECT_EQ(dummy, 0x01);
- EXPECT_FALSE(reader.HasMoreRBSPData());
}

Powered by Google App Engine
This is Rietveld 408576698