Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 10837052: Fix license metadata for mesa (Closed)

Created:
8 years, 4 months ago by Steve Block
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix license metadata for mesa Currently, only the LGPL v2 license from the docs/ subdirectory is mentioned. BUG=138921 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149710

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added note about derivation of license file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
A + third_party/mesa/LICENSE View 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/mesa/README.chromium View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Steve Block
8 years, 4 months ago (2012-08-01 18:00:32 UTC) #1
Alexander Potapenko
I'm hardly a proper reviewer for this. Adding Al and Ken
8 years, 4 months ago (2012-08-02 13:07:59 UTC) #2
Ken Russell (switch to Gerrit)
LGTM with one issue. http://codereview.chromium.org/10837052/diff/1/third_party/mesa/README.chromium File third_party/mesa/README.chromium (left): http://codereview.chromium.org/10837052/diff/1/third_party/mesa/README.chromium#oldcode16 third_party/mesa/README.chromium:16: The license is in MesaLib/docs/license.html. ...
8 years, 4 months ago (2012-08-02 17:55:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/10837052/4
8 years, 4 months ago (2012-08-02 20:27:36 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 21:49:57 UTC) #5
Change committed as 149710

Powered by Google App Engine
This is Rietveld 408576698