sync/protocol/proto_value_conversions_unittest.cc - Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/protocol/proto_value_conversions_unittest.cc

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: David's comments Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/protocol/proto_value_conversions_unittest.cc

diff --git a/sync/protocol/proto_value_conversions_unittest.cc b/sync/protocol/proto_value_conversions_unittest.cc

index 89a99e36c45566679fff6101cf570639762d1629..fd364501d144a89b61ccbc11c0f60c179dd71cbf 100644

--- a/sync/protocol/proto_value_conversions_unittest.cc

+++ b/sync/protocol/proto_value_conversions_unittest.cc

@@ -193,8 +193,8 @@ namespace {

bool ValueHasSpecifics(const DictionaryValue& value,

const std::string& path) {

const ListValue* entities_list = NULL;

- DictionaryValue* entry_dictionary = NULL;

- DictionaryValue* specifics_dictionary = NULL;

+ const DictionaryValue* entry_dictionary = NULL;

+ const DictionaryValue* specifics_dictionary = NULL;

if (!value.GetList(path, &entities_list))

return false;

« no previous file with comments | « sync/internal_api/sync_manager_impl_unittest.cc ('k') | tools/json_schema_compiler/cc_generator.py » ('j') | no next file with comments »