Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3851)

Unified Diff: chrome/common/extensions/api/extension_api.cc

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: David's comments Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/extension_api.cc
diff --git a/chrome/common/extensions/api/extension_api.cc b/chrome/common/extensions/api/extension_api.cc
index 3399bf8d8926e8f3573b11d43e85bf794acafdc4..c8e32955043ad29465afde16eac1a87e63bcc39d 100644
--- a/chrome/common/extensions/api/extension_api.cc
+++ b/chrome/common/extensions/api/extension_api.cc
@@ -56,7 +56,7 @@ bool HasUnprivilegedChild(const DictionaryValue* name_space_node,
if (name_space_node->GetList(child_kind, &child_list)) {
for (size_t i = 0; i < child_list->GetSize(); ++i) {
- DictionaryValue* item = NULL;
+ const DictionaryValue* item = NULL;
CHECK(child_list->GetDictionary(i, &item));
if (IsUnprivileged(item))
return true;
@@ -101,11 +101,11 @@ scoped_ptr<ListValue> LoadSchemaList(const std::string& name,
return scoped_ptr<ListValue>(static_cast<ListValue*>(result.release()));
}
-DictionaryValue* FindListItem(const ListValue* list,
- const std::string& property_name,
- const std::string& property_value) {
+const DictionaryValue* FindListItem(const ListValue* list,
+ const std::string& property_name,
+ const std::string& property_value) {
for (size_t i = 0; i < list->GetSize(); ++i) {
- DictionaryValue* item = NULL;
+ const DictionaryValue* item = NULL;
CHECK(list->GetDictionary(i, &item))
<< property_value << "/" << property_name;
std::string value;
@@ -118,7 +118,7 @@ DictionaryValue* FindListItem(const ListValue* list,
const DictionaryValue* GetSchemaChild(const DictionaryValue* schema_node,
const std::string& child_name) {
- DictionaryValue* child_node = NULL;
+ const DictionaryValue* child_node = NULL;
for (size_t i = 0; i < arraysize(kChildKinds); ++i) {
const ListValue* list_node = NULL;
if (!schema_node->GetList(kChildKinds[i], &list_node))
« no previous file with comments | « chrome/browser/web_resource/notification_promo.cc ('k') | chrome/common/extensions/api/extension_api_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698