chrome/browser/printing/print_job_worker.cc - Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_job_worker.cc

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: David's comments Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/policy_loader_win_unittest.cc ('k') | chrome/browser/search_engines/template_url_prepopulate_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_job_worker.cc

diff --git a/chrome/browser/printing/print_job_worker.cc b/chrome/browser/printing/print_job_worker.cc

index 930c3f35669f3dcb2fcff6b4147fa827fc68253d..90ea9616adc64423daad18b6437227a687a90ab0 100644

--- a/chrome/browser/printing/print_job_worker.cc

+++ b/chrome/browser/printing/print_job_worker.cc

@@ -125,7 +125,7 @@ void PrintJobWorker::UpdatePrintSettings(

const ListValue* page_range_array;

if (new_settings->GetList(kSettingPageRange, &page_range_array)) {

for (size_t index = 0; index < page_range_array->GetSize(); ++index) {

- DictionaryValue* dict;

+ const DictionaryValue* dict;

if (!page_range_array->GetDictionary(index, &dict))

continue;