base/json/json_value_converter.h - Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/json/json_value_converter.h

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: David's comments Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/json/json_value_converter.h

diff --git a/base/json/json_value_converter.h b/base/json/json_value_converter.h

index 9d3036a429abd2aaf4f949995ee69cb8ac2bd8da..69da0d81f207d40ad8b962241fbf423e0ae411e8 100644

--- a/base/json/json_value_converter.h

+++ b/base/json/json_value_converter.h

@@ -273,7 +273,7 @@ class RepeatedValueConverter : public ValueConverter<ScopedVector<Element> > {

field->reserve(list->GetSize());

for (size_t i = 0; i < list->GetSize(); ++i) {

- base::Value* element = NULL;

+ const base::Value* element = NULL;

if (!list->Get(i, &element))

continue;

@@ -307,7 +307,7 @@ class RepeatedMessageConverter

field->reserve(list->GetSize());

for (size_t i = 0; i < list->GetSize(); ++i) {

- base::Value* element = NULL;

+ const base::Value* element = NULL;

if (!list->Get(i, &element))

continue;

@@ -344,7 +344,7 @@ class RepeatedCustomValueConverter

field->reserve(list->GetSize());

for (size_t i = 0; i < list->GetSize(); ++i) {

- base::Value* element = NULL;

+ const base::Value* element = NULL;

if (!list->Get(i, &element))

continue;

« no previous file with comments | « base/debug/trace_event_unittest.cc ('k') | base/json/json_writer.cc » ('j') | no next file with comments »