Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: tools/json_schema_compiler/util.cc

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: David's comments Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/json_schema_compiler/util.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/json_schema_compiler/any.h" 5 #include "tools/json_schema_compiler/any.h"
6 #include "tools/json_schema_compiler/util.h" 6 #include "tools/json_schema_compiler/util.h"
7 7
8 #include "base/values.h" 8 #include "base/values.h"
9 9
10 namespace json_schema_compiler { 10 namespace json_schema_compiler {
(...skipping 10 matching lines...) Expand all
21 bool GetItemFromList(const ListValue& from, int index, double* out) { 21 bool GetItemFromList(const ListValue& from, int index, double* out) {
22 return from.GetDouble(index, out); 22 return from.GetDouble(index, out);
23 } 23 }
24 24
25 bool GetItemFromList(const ListValue& from, int index, std::string* out) { 25 bool GetItemFromList(const ListValue& from, int index, std::string* out) {
26 return from.GetString(index, out); 26 return from.GetString(index, out);
27 } 27 }
28 28
29 bool GetItemFromList(const ListValue& from, int index, 29 bool GetItemFromList(const ListValue& from, int index,
30 linked_ptr<any::Any>* out) { 30 linked_ptr<any::Any>* out) {
31 Value* value = NULL; 31 const Value* value = NULL;
32 if (!from.Get(index, &value)) 32 if (!from.Get(index, &value))
33 return false; 33 return false;
34 scoped_ptr<any::Any> any_object(new any::Any()); 34 scoped_ptr<any::Any> any_object(new any::Any());
35 any_object->Init(*value); 35 any_object->Init(*value);
36 *out = linked_ptr<any::Any>(any_object.release()); 36 *out = linked_ptr<any::Any>(any_object.release());
37 return true; 37 return true;
38 } 38 }
39 39
40 bool GetItemFromList(const ListValue& from, int index, 40 bool GetItemFromList(const ListValue& from, int index,
41 linked_ptr<base::DictionaryValue>* out) { 41 linked_ptr<base::DictionaryValue>* out) {
42 DictionaryValue* dict = NULL; 42 const DictionaryValue* dict = NULL;
43 if (!from.GetDictionary(index, &dict)) 43 if (!from.GetDictionary(index, &dict))
44 return false; 44 return false;
45 *out = linked_ptr<DictionaryValue>(dict->DeepCopy()); 45 *out = linked_ptr<DictionaryValue>(dict->DeepCopy());
46 return true; 46 return true;
47 } 47 }
48 48
49 void AddItemToList(const int from, base::ListValue* out) { 49 void AddItemToList(const int from, base::ListValue* out) {
50 out->Append(base::Value::CreateIntegerValue(from)); 50 out->Append(base::Value::CreateIntegerValue(from));
51 } 51 }
52 void AddItemToList(const bool from, base::ListValue* out) { 52 void AddItemToList(const bool from, base::ListValue* out) {
53 out->Append(base::Value::CreateBooleanValue(from)); 53 out->Append(base::Value::CreateBooleanValue(from));
54 } 54 }
55 void AddItemToList(const double from, base::ListValue* out) { 55 void AddItemToList(const double from, base::ListValue* out) {
56 out->Append(base::Value::CreateDoubleValue(from)); 56 out->Append(base::Value::CreateDoubleValue(from));
57 } 57 }
58 void AddItemToList(const std::string& from, base::ListValue* out) { 58 void AddItemToList(const std::string& from, base::ListValue* out) {
59 out->Append(base::Value::CreateStringValue(from)); 59 out->Append(base::Value::CreateStringValue(from));
60 } 60 }
61 void AddItemToList(const linked_ptr<base::DictionaryValue>& from, 61 void AddItemToList(const linked_ptr<base::DictionaryValue>& from,
62 base::ListValue* out) { 62 base::ListValue* out) {
63 out->Append(static_cast<Value*>(from->DeepCopy())); 63 out->Append(static_cast<Value*>(from->DeepCopy()));
64 } 64 }
65 void AddItemToList(const linked_ptr<any::Any>& from, 65 void AddItemToList(const linked_ptr<any::Any>& from,
66 base::ListValue* out) { 66 base::ListValue* out) {
67 out->Append(from->value().DeepCopy()); 67 out->Append(from->value().DeepCopy());
68 } 68 }
69 69
70 } // namespace api_util 70 } // namespace api_util
71 } // namespace extensions 71 } // namespace extensions
OLDNEW
« no previous file with comments | « tools/json_schema_compiler/util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698