Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 10837003: CPM Refactor and Cleanup (Closed)

Created:
8 years, 4 months ago by Devlin
Modified:
8 years, 4 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@dc_startup_times
Visibility:
Public.

Description

CPM Refactor and Cleanup Refactor CPM events to have a single JSON event for all extension-related events; change EVENT_UNLOAD to EVENT_DISABLE (easier to understand, inline with EVENT_ENABLE); clean up PerformanceMonitor::Observe. BUG=130212 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150938

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Version for CQ #

Patch Set 3 : Merged with latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -374 lines) Patch
M chrome/browser/performance_monitor/database_unittest.cc View 1 3 chunks +26 lines, -20 lines 0 comments Download
M chrome/browser/performance_monitor/event.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/performance_monitor/event.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/performance_monitor/events.json View 1 1 chunk +2 lines, -63 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor.h View 1 5 chunks +29 lines, -22 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor.cc View 1 6 chunks +50 lines, -72 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor_browsertest.cc View 1 9 chunks +23 lines, -41 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor_util.h View 1 chunk +15 lines, -55 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor_util.cc View 2 chunks +11 lines, -99 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Devlin
Follows https://chromiumcodereview.appspot.com/10834015/ (startup timing)
8 years, 4 months ago (2012-07-31 17:24:05 UTC) #1
Yoyo Zhou
Woo hoo! LGTM. http://codereview.chromium.org/10837003/diff/3001/chrome/browser/performance_monitor/events.json File chrome/browser/performance_monitor/events.json (right): http://codereview.chromium.org/10837003/diff/3001/chrome/browser/performance_monitor/events.json#newcode12 chrome/browser/performance_monitor/events.json:12: "description": "The event to describe a ...
8 years, 4 months ago (2012-08-02 08:39:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10837003/12003
8 years, 4 months ago (2012-08-09 20:31:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10837003/9009
8 years, 4 months ago (2012-08-09 20:45:44 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 23:18:02 UTC) #5
Change committed as 150938

Powered by Google App Engine
This is Rietveld 408576698