Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 10837002: Extension docs server: add sys.executable to start_dev_server so that it works better on Windows (w… (Closed)

Created:
8 years, 4 months ago by not at google - send to devlin
Modified:
8 years, 4 months ago
Reviewers:
cduvall
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Extension docs server: add sys.executable to start_dev_server so that it works better on Windows (where Python isn't necessarily in the path). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148981

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/common/extensions/docs/server2/start_dev_server.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
not at google - send to devlin
8 years, 4 months ago (2012-07-30 16:26:31 UTC) #1
cduvall
lgtm
8 years, 4 months ago (2012-07-30 16:53:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/10837002/1
8 years, 4 months ago (2012-07-30 16:54:37 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-07-30 18:28:09 UTC) #4
Change committed as 148981

Powered by Google App Engine
This is Rietveld 408576698