Rename GData* to Drive* in gdata.proto

Rename GData* to Drive* in gdata.proto

* gdata.proto has been renamed to drive.proto.
* The following classes are renamed:
  GDataFileSpecificInfo -> DriveFileSpecificInfo
  GDataEntryProto -> DriveEntryProto
  GDataDirectoryProto -> DriveDirectoryProto
  GDataCacheEntry -> DriveCacheEntry

More GData* to Drive* conversion come in later CLs.

BUG=137151
TEST=pass all trybots
TBR=estade@chromium.com, ben@chromium.org

(estade for chrome/browser/ui/webui, ben for gypi changes)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152539

[kochi, 2012-08-21 08:53:34]

Hi Kazuhiro,

Could you review this?
Thanks!

[kinaba, 2012-08-21 09:15:14]

lgtm, with some (rather irrelevant) nits, which is ok to separate to another CL
if you want.

In three headers, DriveEntryProto has its forward declaration, but not for
DriveEntryProtoVector even though it is used. I think we should be consistent
here and add
typedef std::vector<DriveEntryProto> DriveEntryProtoVector;
there.

http://codereview.chromium.org/10836354/diff/5001/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_file_system_interface.h (right):

http://codereview.chromium.org/10836354/diff/5001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_file_system_interface.h:20: class
DriveEntryProto;
No declaration for DriveEntryProtoVector.

http://codereview.chromium.org/10836354/diff/5001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_file_system_interface.h:21: class
DriveDirectoryProto;
DriveDirectoryProto is not used.

http://codereview.chromium.org/10836354/diff/5001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_file_system_interface.h:22: class
GDataFileProto;
It seems GDataFileProto is obsolete. Please remove this fwd decl.

http://codereview.chromium.org/10836354/diff/5001/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_file_system_proxy.h (right):

http://codereview.chromium.org/10836354/diff/5001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_file_system_proxy.h:18: class
DriveEntryProto;
No declaration for DriveEntryProtoVector.

http://codereview.chromium.org/10836354/diff/5001/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_test_util.h (right):

http://codereview.chromium.org/10836354/diff/5001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_test_util.h:17: class DriveEntryProto;
No declaration for DriveEntryProtoVector.

[achuithb, 2012-08-21 09:23:45]

https://chromiumcodereview.appspot.com/10836354/diff/5001/chrome/browser/chro...
File chrome/browser/chromeos/gdata/gdata_directory_service.h (right):

https://chromiumcodereview.appspot.com/10836354/diff/5001/chrome/browser/chro...
chrome/browser/chromeos/gdata/gdata_directory_service.h:65: const int32
kProtoVersion = 2;
I think you also need to bump this number to 3.

[achuithb, 2012-08-21 09:28:35]

I think it would be helpful if you could note all the classes and files that
have changed in the CL description.

For example,

* gdata.proto has been renamed to drive.proto. 
* The following classes are renamed: GDataFileSpecificInfo, GDataEntryProto,
GDataFileProto, GDataDirectoryProto, GDataEntry, GDataFile, GDataDirectory, etc.

[kochi, 2012-08-21 09:37:34]

Thanks for the reviews!

I've updated the description as well.

https://chromiumcodereview.appspot.com/10836354/diff/5001/chrome/browser/chro...
File chrome/browser/chromeos/gdata/gdata_directory_service.h (right):

https://chromiumcodereview.appspot.com/10836354/diff/5001/chrome/browser/chro...
chrome/browser/chromeos/gdata/gdata_directory_service.h:65: const int32
kProtoVersion = 2;
On 2012/08/21 09:23:45, achuith.bhandarkar wrote:
> I think you also need to bump this number to 3.

I don't think so.
The name of the proto is changed, but the cardinals of the
proto members are unchanged, thus the saved protos can
be read as is by the renamed new protos.

https://chromiumcodereview.appspot.com/10836354/diff/5001/chrome/browser/chro...
File chrome/browser/chromeos/gdata/gdata_file_system_interface.h (right):

https://chromiumcodereview.appspot.com/10836354/diff/5001/chrome/browser/chro...
chrome/browser/chromeos/gdata/gdata_file_system_interface.h:20: class
DriveEntryProto;
On 2012/08/21 09:15:14, kinaba wrote:
> No declaration for DriveEntryProtoVector.

Done.

https://chromiumcodereview.appspot.com/10836354/diff/5001/chrome/browser/chro...
chrome/browser/chromeos/gdata/gdata_file_system_interface.h:21: class
DriveDirectoryProto;
On 2012/08/21 09:15:14, kinaba wrote:
> DriveDirectoryProto is not used.

Good catch! Done.

https://chromiumcodereview.appspot.com/10836354/diff/5001/chrome/browser/chro...
chrome/browser/chromeos/gdata/gdata_file_system_interface.h:22: class
GDataFileProto;
On 2012/08/21 09:15:14, kinaba wrote:
> It seems GDataFileProto is obsolete. Please remove this fwd decl.

Done.

https://chromiumcodereview.appspot.com/10836354/diff/5001/chrome/browser/chro...
File chrome/browser/chromeos/gdata/gdata_file_system_proxy.h (right):

https://chromiumcodereview.appspot.com/10836354/diff/5001/chrome/browser/chro...
chrome/browser/chromeos/gdata/gdata_file_system_proxy.h:18: class
DriveEntryProto;
On 2012/08/21 09:15:14, kinaba wrote:
> No declaration for DriveEntryProtoVector.

Done.

https://chromiumcodereview.appspot.com/10836354/diff/5001/chrome/browser/chro...
File chrome/browser/chromeos/gdata/gdata_test_util.h (right):

https://chromiumcodereview.appspot.com/10836354/diff/5001/chrome/browser/chro...
chrome/browser/chromeos/gdata/gdata_test_util.h:17: class DriveEntryProto;
On 2012/08/21 09:15:14, kinaba wrote:
> No declaration for DriveEntryProtoVector.

Done.

[achuithb, 2012-08-21 09:41:30]

lgtm

[kochi, 2012-08-21 09:58:29]

Added TBR= line.

Evan, could you check chrome/browser/ui/webui/feedback_ui.cc?
Ben, could you check chrome_browser.gypi changes?

Thanks,

[Evan Stade, 2012-08-22 00:19:53]

feedback_ui.cc lgtm