Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 10836348: Enforce issue and patchset being a number in most Rietveld APIs. (Closed)

Created:
8 years, 4 months ago by M-A Ruel
Modified:
8 years, 4 months ago
Reviewers:
cmp
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org
Visibility:
Public.

Description

Enforce issue and patchset being a number in most Rietveld APIs. This ensures we don't send incorrect values like None or random strings. R=cmp@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152756

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M rietveld.py View 7 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
8 years, 4 months ago (2012-08-20 19:29:09 UTC) #1
cmp
lgtm
8 years, 4 months ago (2012-08-22 07:08:09 UTC) #2
M-A Ruel
On 2012/08/22 07:08:09, cmp wrote: > lgtm (BTW this may break stuff, I'll revert if ...
8 years, 4 months ago (2012-08-22 11:57:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10836348/1
8 years, 4 months ago (2012-08-22 11:57:33 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-22 12:00:44 UTC) #5
Change committed as 152756

Powered by Google App Engine
This is Rietveld 408576698