Chromium Code Reviews
Help | Chromium Project | Sign in
(558)

Issue 10836347: Add support for multiple browser instances reliability tests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by chrisphan
Modified:
1 year, 5 months ago
Reviewers:
cmp, sky
CC:
chromium-reviews_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Add support for running multiple browser instances with reliability tests.

Originally, crash_service.exe dumps all encountered crash dump files into a single directory. But if multiple browser instances are running, we want to identify which crash belongs to which browser instance.

- Add a flag to crash service to archive the generated crash dumps under directory by the browser process id.
- Add a flag to page_load_tests to look for crashes under the directory by the process id.

For example:
%USERPROFILE%\AppData\Local\Google\CrashReports\pid\3f4233fhs.dmp

NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165702

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -14 lines) Lint Patch
M chrome/test/reliability/page_load_test.cc View 1 2 3 4 10 chunks +27 lines, -8 lines 1 comment 0 errors Download
M chrome/tools/crash_service/crash_service.h View 2 chunks +6 lines, -0 lines 0 comments 0 errors Download
M chrome/tools/crash_service/crash_service.cc View 1 2 3 4 chunks +24 lines, -6 lines 1 comment 0 errors Download
Commit:

Messages

Total messages: 14
chrisphan
1 year, 8 months ago #1
chrisphan
On 2012/08/20 19:20:46, chrisphan wrote: Hi Chase, when you have time can you take a ...
1 year, 6 months ago #2
cmp
http://codereview.chromium.org/10836347/diff/9002/chrome/test/reliability/page_load_test.cc File chrome/test/reliability/page_load_test.cc (right): http://codereview.chromium.org/10836347/diff/9002/chrome/test/reliability/page_load_test.cc#newcode34 chrome/test/reliability/page_load_test.cc:34: // --dumpsbypid: Look for crash dumps by browser process ...
1 year, 6 months ago #3
chrisphan
http://codereview.chromium.org/10836347/diff/9002/chrome/test/reliability/page_load_test.cc File chrome/test/reliability/page_load_test.cc (right): http://codereview.chromium.org/10836347/diff/9002/chrome/test/reliability/page_load_test.cc#newcode34 chrome/test/reliability/page_load_test.cc:34: // --dumpsbypid: Look for crash dumps by browser process ...
1 year, 6 months ago #4
chrisphan
On 2012/10/02 23:10:51, chrisphan wrote: > http://codereview.chromium.org/10836347/diff/9002/chrome/test/reliability/page_load_test.cc > File chrome/test/reliability/page_load_test.cc (right): > > http://codereview.chromium.org/10836347/diff/9002/chrome/test/reliability/page_load_test.cc#newcode34 > ...
1 year, 6 months ago #5
cmp
lgtm
1 year, 5 months ago #6
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisphan@chromium.org/10836347/14001
1 year, 5 months ago #7
I haz the power (commit-bot)
Presubmit check for 10836347-14001 failed and returned exit status 1. Running presubmit commit checks ...
1 year, 5 months ago #8
cmp
Not sure who added sky, but you beat me to it. +sky, can you take ...
1 year, 5 months ago #9
sky
LGTM https://chromiumcodereview.appspot.com/10836347/diff/14001/chrome/test/reliability/page_load_test.cc File chrome/test/reliability/page_load_test.cc (right): https://chromiumcodereview.appspot.com/10836347/diff/14001/chrome/test/reliability/page_load_test.cc#newcode127 chrome/test/reliability/page_load_test.cc:127: bool g_stand_alone = false; None of the these ...
1 year, 5 months ago #10
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisphan@chromium.org/10836347/14001
1 year, 5 months ago #11
I haz the power (commit-bot)
Step "update" is always a major failure. Look at the try server FAQ for more ...
1 year, 5 months ago #12
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisphan@chromium.org/10836347/14001
1 year, 5 months ago #13
I haz the power (commit-bot)
1 year, 5 months ago #14
Change committed as 165702
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6