Add support for multiple browser instances reliability tests.

Add support for running multiple browser instances with reliability tests. 

Originally, crash_service.exe dumps all encountered crash dump files into a single directory. But if multiple browser instances are running, we want to identify which crash belongs to which browser instance. 

- Add a flag to crash service to archive the generated crash dumps under directory by the browser process id. 
- Add a flag to page_load_tests to look for crashes under the directory by the process id. 

For example: 
%USERPROFILE%\AppData\Local\Google\CrashReports\pid\3f4233fhs.dmp

NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165702

[chrisphan, 2012-09-27 21:31:30]

On 2012/08/20 19:20:46, chrisphan wrote:

Hi Chase, when you have time can you take a look at this?

[cmp, 2012-10-02 19:47:28]

http://codereview.chromium.org/10836347/diff/9002/chrome/test/reliability/pag...
File chrome/test/reliability/page_load_test.cc (right):

http://codereview.chromium.org/10836347/diff/9002/chrome/test/reliability/pag...
chrome/test/reliability/page_load_test.cc:34: // --dumpsbypid: Look for crash
dumps by browser process id. 'crash_dir/pid/'
dumpsbypid -> searchdumpsbypid

http://codereview.chromium.org/10836347/diff/9002/chrome/test/reliability/pag...
chrome/test/reliability/page_load_test.cc:341: 
i assume in an else condition for the condition on line 333
actual_crash_dumps_dir_path should be set to FilePath(crash_dumps_dir_path_)?

[chrisphan, 2012-10-02 23:10:51]

http://codereview.chromium.org/10836347/diff/9002/chrome/test/reliability/pag...
File chrome/test/reliability/page_load_test.cc (right):

http://codereview.chromium.org/10836347/diff/9002/chrome/test/reliability/pag...
chrome/test/reliability/page_load_test.cc:34: // --dumpsbypid: Look for crash
dumps by browser process id. 'crash_dir/pid/'
On 2012/10/02 19:47:28, cmp wrote:
> dumpsbypid -> searchdumpsbypid

Done.

http://codereview.chromium.org/10836347/diff/9002/chrome/test/reliability/pag...
chrome/test/reliability/page_load_test.cc:341: 
On 2012/10/02 19:47:28, cmp wrote:
> i assume in an else condition for the condition on line 333
> actual_crash_dumps_dir_path should be set to FilePath(crash_dumps_dir_path_)?

crash_dumps_dir_path_ is already set on SetUp().

[chrisphan, 2012-10-16 21:28:15]

On 2012/10/02 23:10:51, chrisphan wrote:
>
http://codereview.chromium.org/10836347/diff/9002/chrome/test/reliability/pag...
> File chrome/test/reliability/page_load_test.cc (right):
> 
>
http://codereview.chromium.org/10836347/diff/9002/chrome/test/reliability/pag...
> chrome/test/reliability/page_load_test.cc:34: // --dumpsbypid: Look for crash
> dumps by browser process id. 'crash_dir/pid/'
> On 2012/10/02 19:47:28, cmp wrote:
> > dumpsbypid -> searchdumpsbypid
> 
> Done.
> 
>
http://codereview.chromium.org/10836347/diff/9002/chrome/test/reliability/pag...
> chrome/test/reliability/page_load_test.cc:341: 
> On 2012/10/02 19:47:28, cmp wrote:
> > i assume in an else condition for the condition on line 333
> > actual_crash_dumps_dir_path should be set to
FilePath(crash_dumps_dir_path_)?
> 
> crash_dumps_dir_path_ is already set on SetUp().

Is everything here good to go?

[cmp, 2012-11-01 23:53:22]

lgtm

[commit-bot: I haz the power, 2012-11-01 23:54:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisphan@chromium.org/10836347/14001

[commit-bot: I haz the power, 2012-11-01 23:54:34]

Presubmit check for 10836347-14001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome
    chrome/test

[cmp, 2012-11-02 00:36:24]

Not sure who added sky, but you beat me to it.  +sky, can you take a look?

[sky, 2012-11-02 15:03:04]

LGTM

https://chromiumcodereview.appspot.com/10836347/diff/14001/chrome/test/reliab...
File chrome/test/reliability/page_load_test.cc (right):

https://chromiumcodereview.appspot.com/10836347/diff/14001/chrome/test/reliab...
chrome/test/reliability/page_load_test.cc:127: bool g_stand_alone = false;
None of the these are global. They shouldn't have g_. You can fix that
separately if you want.

https://chromiumcodereview.appspot.com/10836347/diff/14001/chrome/tools/crash...
File chrome/tools/crash_service/crash_service.cc (right):

https://chromiumcodereview.appspot.com/10836347/diff/14001/chrome/tools/crash...
chrome/tools/crash_service/crash_service.cc:157: bool
CrashService::archive_dumps_by_pid_ = false;
// static on the previous line.

[commit-bot: I haz the power, 2012-11-02 17:35:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisphan@chromium.org/10836347/14001

[commit-bot: I haz the power, 2012-11-02 17:54:21]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-02 18:00:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisphan@chromium.org/10836347/14001

[commit-bot: I haz the power, 2012-11-02 18:00:49]

Change committed as 165702