Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 10836343: Handle link annotations in Skia EMF device. (Closed)

Created:
8 years, 4 months ago by vandebo (ex-Chrome)
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Handle link annotations in Skia EMF device. See Skia r4555 BUG=140184 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152433

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M skia/ext/vector_platform_device_emf_win.cc View 3 chunks +5 lines, -0 lines 1 comment Download

Messages

Total messages: 11 (0 generated)
vandebo (ex-Chrome)
8 years, 4 months ago (2012-08-20 18:43:58 UTC) #1
vandebo (ex-Chrome)
+reed
8 years, 4 months ago (2012-08-20 20:34:28 UTC) #2
Vitaly Buka (NO REVIEWS)
https://chromiumcodereview.appspot.com/10836343/diff/1/skia/ext/vector_platform_device_emf_win.cc File skia/ext/vector_platform_device_emf_win.cc (right): https://chromiumcodereview.appspot.com/10836343/diff/1/skia/ext/vector_platform_device_emf_win.cc#newcode19 skia/ext/vector_platform_device_emf_win.cc:19: do { if (paint.isNoDrawAnnotation()) { return; } } while ...
8 years, 4 months ago (2012-08-20 20:36:45 UTC) #3
vandebo (ex-Chrome)
On 2012/08/20 20:36:45, Vitaly Buka wrote: > https://chromiumcodereview.appspot.com/10836343/diff/1/skia/ext/vector_platform_device_emf_win.cc > File skia/ext/vector_platform_device_emf_win.cc (right): > > https://chromiumcodereview.appspot.com/10836343/diff/1/skia/ext/vector_platform_device_emf_win.cc#newcode19 ...
8 years, 4 months ago (2012-08-20 20:41:11 UTC) #4
Vitaly Buka (NO REVIEWS)
lgtm But i'd replaced macro in all 3 places with simple if (paint.isNoDrawAnnotation()) return; On ...
8 years, 4 months ago (2012-08-20 20:44:26 UTC) #5
vandebo (ex-Chrome)
On 2012/08/20 20:44:26, Vitaly Buka wrote: > lgtm > > But i'd replaced macro in ...
8 years, 4 months ago (2012-08-20 20:51:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10836343/1
8 years, 4 months ago (2012-08-20 20:52:02 UTC) #7
Vitaly Buka (NO REVIEWS)
Thanks for fixing that.
8 years, 4 months ago (2012-08-20 21:25:28 UTC) #8
vandebo (ex-Chrome)
On 2012/08/20 21:25:28, Vitaly Buka wrote: > Thanks for fixing that. No problem, but mistake ...
8 years, 4 months ago (2012-08-20 21:27:02 UTC) #9
Vitaly Buka (NO REVIEWS)
LGTM I don't think so about CQ, but just in case :-)
8 years, 4 months ago (2012-08-20 21:49:23 UTC) #10
commit-bot: I haz the power
8 years, 4 months ago (2012-08-20 23:53:00 UTC) #11
Change committed as 152433

Powered by Google App Engine
This is Rietveld 408576698