Handle link annotations in Skia EMF device.

Handle link annotations in Skia EMF device.

See Skia r4555

BUG=140184
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152433

[vandebo (ex-Chrome), 2012-08-20 20:34:28]

+reed

[Vitaly Buka (NO REVIEWS), 2012-08-20 20:36:45]

https://chromiumcodereview.appspot.com/10836343/diff/1/skia/ext/vector_platfo...
File skia/ext/vector_platform_device_emf_win.cc (right):

https://chromiumcodereview.appspot.com/10836343/diff/1/skia/ext/vector_platfo...
skia/ext/vector_platform_device_emf_win.cc:19: do { if
(paint.isNoDrawAnnotation()) { return; } } while (0)
Why do you need macro for two instances of such simple check?

[vandebo (ex-Chrome), 2012-08-20 20:41:11]

On 2012/08/20 20:36:45, Vitaly Buka wrote:
>
https://chromiumcodereview.appspot.com/10836343/diff/1/skia/ext/vector_platfo...
> File skia/ext/vector_platform_device_emf_win.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10836343/diff/1/skia/ext/vector_platfo...
> skia/ext/vector_platform_device_emf_win.cc:19: do { if
> (paint.isNoDrawAnnotation()) { return; } } while (0)
> Why do you need macro for two instances of such simple check?

It's not strictly needed; that's how it's done in the other skia devices that
ignore the annotation calls: SkDevice, SkGpuDevice.

[Vitaly Buka (NO REVIEWS), 2012-08-20 20:44:26]

lgtm

But i'd replaced macro in all 3 places with simple 

if (paint.isNoDrawAnnotation())
  return;


On 2012/08/20 20:41:11, vandebo wrote:
> On 2012/08/20 20:36:45, Vitaly Buka wrote:
> >
>
https://chromiumcodereview.appspot.com/10836343/diff/1/skia/ext/vector_platfo...
> > File skia/ext/vector_platform_device_emf_win.cc (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/10836343/diff/1/skia/ext/vector_platfo...
> > skia/ext/vector_platform_device_emf_win.cc:19: do { if
> > (paint.isNoDrawAnnotation()) { return; } } while (0)
> > Why do you need macro for two instances of such simple check?
> 
> It's not strictly needed; that's how it's done in the other skia devices that
> ignore the annotation calls: SkDevice, SkGpuDevice.

[vandebo (ex-Chrome), 2012-08-20 20:51:49]

On 2012/08/20 20:44:26, Vitaly Buka wrote:
> lgtm
> 
> But i'd replaced macro in all 3 places with simple 
> 
> if (paint.isNoDrawAnnotation())
>   return;
> 
> 
> On 2012/08/20 20:41:11, vandebo wrote:
> > On 2012/08/20 20:36:45, Vitaly Buka wrote:
> > >
> >
>
https://chromiumcodereview.appspot.com/10836343/diff/1/skia/ext/vector_platfo...
> > > File skia/ext/vector_platform_device_emf_win.cc (right):
> > > 
> > >
> >
>
https://chromiumcodereview.appspot.com/10836343/diff/1/skia/ext/vector_platfo...
> > > skia/ext/vector_platform_device_emf_win.cc:19: do { if
> > > (paint.isNoDrawAnnotation()) { return; } } while (0)
> > > Why do you need macro for two instances of such simple check?
> > 
> > It's not strictly needed; that's how it's done in the other skia devices
that
> > ignore the annotation calls: SkDevice, SkGpuDevice.

I'll submit this fix for now and discuss with Mike cleaning up the Macro.  The
other two instance are in the skia repository.

[commit-bot: I haz the power, 2012-08-20 20:52:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vandebo@chromium.org/10836343/1

[Vitaly Buka (NO REVIEWS), 2012-08-20 21:25:28]

Thanks for fixing that.

[vandebo (ex-Chrome), 2012-08-20 21:27:02]

On 2012/08/20 21:25:28, Vitaly Buka wrote:
> Thanks for fixing that.

No problem, but mistake in the first place.

BTW - I think CQ will see your new comment and abort the commit unless you add
another LGTM.

[Vitaly Buka (NO REVIEWS), 2012-08-20 21:49:23]

LGTM

I don't think so about CQ, but just in case :-)

[commit-bot: I haz the power, 2012-08-20 23:53:00]

Change committed as 152433