Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: lib/compiler/implementation/ssa/nodes.dart

Issue 10836339: Get rid of the name in HInvokeDynamic (just use the selector instead). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix checked mode. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/codegen.dart ('k') | lib/compiler/implementation/ssa/optimize.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/nodes.dart
diff --git a/lib/compiler/implementation/ssa/nodes.dart b/lib/compiler/implementation/ssa/nodes.dart
index 9b5e2ef03b5396e24edec191d0c66215b56312e0..8e544605d2645b201bd9c36d6afa5ab327ebb94e 100644
--- a/lib/compiler/implementation/ssa/nodes.dart
+++ b/lib/compiler/implementation/ssa/nodes.dart
@@ -1159,11 +1159,10 @@ class HInvoke extends HInstruction {
class HInvokeDynamic extends HInvoke {
final Selector selector;
Element element;
- SourceString name;
- HInvokeDynamic(this.selector, this.element, this.name,
- List<HInstruction> inputs) : super(inputs);
- toString() => 'invoke dynamic: $name';
+ HInvokeDynamic(this.selector, this.element, List<HInstruction> inputs)
+ : super(inputs);
+ toString() => 'invoke dynamic: $selector';
HInstruction get receiver() => inputs[0];
// TODO(floitsch): make class abstract instead of adding an abstract method.
@@ -1172,42 +1171,38 @@ class HInvokeDynamic extends HInvoke {
class HInvokeClosure extends HInvokeDynamic {
HInvokeClosure(Selector selector, List<HInstruction> inputs)
- : super(selector, null, const SourceString('call'), inputs);
+ : super(selector, null, inputs);
accept(HVisitor visitor) => visitor.visitInvokeClosure(this);
}
class HInvokeDynamicMethod extends HInvokeDynamic {
- HInvokeDynamicMethod(Selector selector,
- SourceString methodName,
- List<HInstruction> inputs)
- : super(selector, null, methodName, inputs);
- toString() => 'invoke dynamic method: $name';
+ HInvokeDynamicMethod(Selector selector, List<HInstruction> inputs)
+ : super(selector, null, inputs);
+ toString() => 'invoke dynamic method: $selector';
accept(HVisitor visitor) => visitor.visitInvokeDynamicMethod(this);
}
class HInvokeDynamicField extends HInvokeDynamic {
- HInvokeDynamicField(Selector selector,
- Element element,
- SourceString name,
- List<HInstruction>inputs)
- : super(selector, element, name, inputs);
- toString() => 'invoke dynamic field: $name';
+ HInvokeDynamicField(Selector selector, Element element,
+ List<HInstruction> inputs)
+ : super(selector, element, inputs);
+ toString() => 'invoke dynamic field: $selector';
// TODO(floitsch): make class abstract instead of adding an abstract method.
abstract accept(HVisitor visitor);
}
class HInvokeDynamicGetter extends HInvokeDynamicField {
- HInvokeDynamicGetter(selector, element, name, receiver)
- : super(selector, element, name, [receiver]);
- toString() => 'invoke dynamic getter: $name';
+ HInvokeDynamicGetter(selector, element, receiver)
+ : super(selector, element,[receiver]);
+ toString() => 'invoke dynamic getter: $selector';
accept(HVisitor visitor) => visitor.visitInvokeDynamicGetter(this);
}
class HInvokeDynamicSetter extends HInvokeDynamicField {
- HInvokeDynamicSetter(selector, element, name, receiver, value)
- : super(selector, element, name, [receiver, value]);
- toString() => 'invoke dynamic setter: $name';
+ HInvokeDynamicSetter(selector, element, receiver, value)
+ : super(selector, element, [receiver, value]);
+ toString() => 'invoke dynamic setter: $selector';
accept(HVisitor visitor) => visitor.visitInvokeDynamicSetter(this);
}
« no previous file with comments | « lib/compiler/implementation/ssa/codegen.dart ('k') | lib/compiler/implementation/ssa/optimize.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698