Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Side by Side Diff: lib/compiler/implementation/ssa/tracer.dart

Issue 10836339: Get rid of the name in HInvokeDynamic (just use the selector instead). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix checked mode. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library('tracer'); 5 #library('tracer');
6 6
7 #import('dart:io'); 7 #import('dart:io');
8 #import('ssa.dart'); 8 #import('ssa.dart');
9 #import('../js_backend/js_backend.dart'); 9 #import('../js_backend/js_backend.dart');
10 #import('../leg.dart'); 10 #import('../leg.dart');
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 String visitIntegerCheck(HIntegerCheck node) { 311 String visitIntegerCheck(HIntegerCheck node) {
312 String value = temporaryId(node.value); 312 String value = temporaryId(node.value);
313 return "Integer check: $value"; 313 return "Integer check: $value";
314 } 314 }
315 315
316 String visitInvokeClosure(HInvokeClosure node) 316 String visitInvokeClosure(HInvokeClosure node)
317 => visitInvokeDynamic(node, "closure"); 317 => visitInvokeDynamic(node, "closure");
318 318
319 String visitInvokeDynamic(HInvokeDynamic invoke, String kind) { 319 String visitInvokeDynamic(HInvokeDynamic invoke, String kind) {
320 String receiver = temporaryId(invoke.receiver); 320 String receiver = temporaryId(invoke.receiver);
321 String target = "($kind) $receiver.${invoke.name.slowToString()}"; 321 String name = invoke.selector.name.slowToString();
322 String target = "($kind) $receiver.$name";
322 int offset = HInvoke.ARGUMENTS_OFFSET; 323 int offset = HInvoke.ARGUMENTS_OFFSET;
323 List arguments = 324 List arguments =
324 invoke.inputs.getRange(offset, invoke.inputs.length - offset); 325 invoke.inputs.getRange(offset, invoke.inputs.length - offset);
325 return visitGenericInvoke("Invoke", target, arguments); 326 return visitGenericInvoke("Invoke", target, arguments);
326 } 327 }
327 328
328 String visitInvokeDynamicMethod(HInvokeDynamicMethod node) 329 String visitInvokeDynamicMethod(HInvokeDynamicMethod node)
329 => visitInvokeDynamic(node, "method"); 330 => visitInvokeDynamic(node, "method");
330 String visitInvokeDynamicGetter(HInvokeDynamicGetter node) 331 String visitInvokeDynamicGetter(HInvokeDynamicGetter node)
331 => visitInvokeDynamic(node, "get"); 332 => visitInvokeDynamic(node, "get");
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
514 515
515 String visitIs(HIs node) { 516 String visitIs(HIs node) {
516 String type = node.typeExpression.toString(); 517 String type = node.typeExpression.toString();
517 return "TypeTest: ${temporaryId(node.expression)} is $type"; 518 return "TypeTest: ${temporaryId(node.expression)} is $type";
518 } 519 }
519 520
520 String visitTypeConversion(HTypeConversion node) { 521 String visitTypeConversion(HTypeConversion node) {
521 return "TypeConversion: ${temporaryId(node.inputs[0])} to ${node.type}"; 522 return "TypeConversion: ${temporaryId(node.inputs[0])} to ${node.type}";
522 } 523 }
523 } 524 }
OLDNEW
« no previous file with comments | « lib/compiler/implementation/ssa/optimize.dart ('k') | tests/language/compound_assignment_operator_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698