Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: runtime/bin/process_win.cc

Issue 10836337: Fix dart:io Process callback on Windows platfrom calling convention from cdecl to stdcall. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process_win.cc
diff --git a/runtime/bin/process_win.cc b/runtime/bin/process_win.cc
index ca4d1473f0d0c0a14f41160503c6d4c12d43f0b8..e9cab3055c75061c9287cda9293179ff7bd73dc7 100644
--- a/runtime/bin/process_win.cc
+++ b/runtime/bin/process_win.cc
@@ -74,7 +74,7 @@ class ProcessInfoList {
BOOL success = RegisterWaitForSingleObject(
&wait_handle,
handle,
- reinterpret_cast<WAITORTIMERCALLBACK>(ExitCodeCallback),
+ &ExitCodeCallback,
reinterpret_cast<void*>(pid),
INFINITE,
WT_EXECUTEONLYONCE);
@@ -128,7 +128,7 @@ class ProcessInfoList {
private:
// Callback called when an exit code is available from one of the
// processes in the list.
- static void ExitCodeCallback(void* data, bool timed_out) {
+ static void CALLBACK ExitCodeCallback(PVOID data, BOOLEAN timed_out) {
if (timed_out) return;
DWORD pid = reinterpret_cast<DWORD>(data);
HANDLE handle;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698