Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 10836324: Panels test cleanup. (Closed)

Created:
8 years, 4 months ago by jennb
Modified:
8 years, 4 months ago
Reviewers:
jianli
CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng
Visibility:
Public.

Description

Panels test cleanup. Make MinimizeImmediatelyAfterRestore set up signal prior to action. Simplify expansion state checks. They're not async. More waiting in AutoResize test to avoid resizing content before it has finished sizing itself. BUG=None TEST=Updated/cleaned up. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152225

Patch Set 1 #

Total comments: 2

Patch Set 2 : feedback change to remove redundant if-check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -43 lines) Patch
M chrome/browser/ui/panels/base_panel_browser_test.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 chunk +10 lines, -18 lines 0 comments Download
M chrome/browser/ui/panels/panel.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 5 chunks +16 lines, -10 lines 0 comments Download
M chrome/browser/ui/panels/panel_gtk.cc View 1 2 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jennb
Trying to make some panel tests less flaky...
8 years, 4 months ago (2012-08-17 23:53:54 UTC) #1
jianli
lgtm http://codereview.chromium.org/10836324/diff/1/chrome/browser/ui/panels/panel_gtk.cc File chrome/browser/ui/panels/panel_gtk.cc (right): http://codereview.chromium.org/10836324/diff/1/chrome/browser/ui/panels/panel_gtk.cc#newcode775 chrome/browser/ui/panels/panel_gtk.cc:775: } else if (is_shown_) { Is this if ...
8 years, 4 months ago (2012-08-18 00:07:57 UTC) #2
jennb
http://codereview.chromium.org/10836324/diff/1/chrome/browser/ui/panels/panel_gtk.cc File chrome/browser/ui/panels/panel_gtk.cc (right): http://codereview.chromium.org/10836324/diff/1/chrome/browser/ui/panels/panel_gtk.cc#newcode775 chrome/browser/ui/panels/panel_gtk.cc:775: } else if (is_shown_) { On 2012/08/18 00:07:57, jianli ...
8 years, 4 months ago (2012-08-18 00:28:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennb@chromium.org/10836324/7002
8 years, 4 months ago (2012-08-18 01:01:05 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-18 02:32:30 UTC) #5
Change committed as 152225

Powered by Google App Engine
This is Rietveld 408576698