Change Android build configurations (step 2).

Change Android build configurations (step 2).

Step 1 is https://chromiumcodereview.appspot.com/10827273/ which changed
Debug build to build size-optimized code with DCHECK.

Step 2: update developer scripts and buildbot scripts to support to new
configurations.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152468

[Xianzhu, 2012-08-17 22:33:28]

Most of this CL has been in downstream except 1) parts belong to a bigger part
not upstreamed, 2) Release to Debug in bb_extract_build() in buildbot.sh
(actually I don't know what this exactly does. Just guess it's correct but might
be wrong).

[Torne, 2012-08-20 10:21:57]

Looks okay but I don't really know anything about these test scripts.

[Satish, 2012-08-20 11:24:31]

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/android/gdb_c...
File build/android/gdb_content_shell (left):

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/android/gdb_c...
build/android/gdb_content_shell:14: exec ${ROOT}/gdb_apk -r -p
org.chromium.content_shell -l ${ROOT}/../../out/Release/lib.target/
is it not required to pass the lib.target path for the appropriate build type
anymore?

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/android/pylib...
File build/android/pylib/chrome_test_server_spawner.py (left):

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/android/pylib...
build/android/pylib/chrome_test_server_spawner.py:105:
self.server.serve_forever()
how is this change related to the rest of this CL?

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/android/pylib...
File build/android/pylib/forwarder.py (left):

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/android/pylib...
build/android/pylib/forwarder.py:34: host_name: Optional. Address to forward to,
must be addressable from the
is this not optional anymore?

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/common.gypi
File build/common.gypi (left):

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/common.gypi#o...
build/common.gypi:2040: '-fno-ident',
how is this change related to the rest of this CL?

[Satish, 2012-08-20 11:29:23]

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/android/build...
File build/android/buildbot_functions.sh (right):

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/android/build...
build/android/buildbot_functions.sh:282: --target Debug \
I see all other places where you switch from Release to Debug are in the 'Step
3' CL https://chromiumcodereview.appspot.com/10831381/. Should this line of
change also move to that CL?

[Xianzhu, 2012-08-20 17:54:58]

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/android/build...
File build/android/buildbot_functions.sh (right):

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/android/build...
build/android/buildbot_functions.sh:282: --target Debug \
On 2012/08/20 11:29:24, Satish wrote:
> I see all other places where you switch from Release to Debug are in the 'Step
> 3' CL https://chromiumcodereview.appspot.com/10831381/. Should this line of
> change also move to that CL?

Yes, this one should be in the CL of Step 3.

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/android/gdb_c...
File build/android/gdb_content_shell (left):

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/android/gdb_c...
build/android/gdb_content_shell:14: exec ${ROOT}/gdb_apk -r -p
org.chromium.content_shell -l ${ROOT}/../../out/Release/lib.target/
On 2012/08/20 11:24:31, Satish wrote:
> is it not required to pass the lib.target path for the appropriate build type
> anymore?

It's not required because it is just the default value used in gdb_apk.

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/android/pylib...
File build/android/pylib/chrome_test_server_spawner.py (left):

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/android/pylib...
build/android/pylib/chrome_test_server_spawner.py:105:
self.server.serve_forever()
On 2012/08/20 11:24:31, Satish wrote:
> how is this change related to the rest of this CL?

Thanks for the catch! Fixed.

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/android/pylib...
File build/android/pylib/forwarder.py (left):

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/android/pylib...
build/android/pylib/forwarder.py:34: host_name: Optional. Address to forward to,
must be addressable from the
On 2012/08/20 11:24:31, Satish wrote:
> is this not optional anymore?

It has never been optional. It doesn't have a default value, and all call sites
specify the value.

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/common.gypi
File build/common.gypi (left):

https://chromiumcodereview.appspot.com/10836323/diff/4001/build/common.gypi#o...
build/common.gypi:2040: '-fno-ident',
On 2012/08/20 11:24:31, Satish wrote:
> how is this change related to the rest of this CL?

The flag breaks clang build. I tried to use a condition to disable it, but
finally I found the flag affects nothing. More details are in downstream CL
23624.

[Satish, 2012-08-20 20:31:23]

lgtm

[commit-bot: I haz the power, 2012-08-20 20:46:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10836323/2002

[commit-bot: I haz the power, 2012-08-21 01:05:07]

List of reviewers changed. ilevy@chromium.org did a drive-by without LGTM'ing!

[commit-bot: I haz the power, 2012-08-21 01:25:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10836323/2002

[Xianzhu, 2012-08-21 01:26:58]

Don't want to want for another 4 hours of CQ. Submitted manually with dcommit.