Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 10836319: Improve i18n date/time test performance (Closed)

Created:
8 years, 4 months ago by Alan Knight
Modified:
8 years, 4 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Improve i18n date/time test performance Committed: https://code.google.com/p/dart/source/detail?r=10986

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M pkg/i18n/lib/date_format_helpers.dart View 1 chunk +4 lines, -2 lines 1 comment Download
M pkg/i18n/test/date_time_format_test.dart View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Alan Knight
It was annoying me that the date/time tests took so long to run, so did ...
8 years, 4 months ago (2012-08-17 20:06:49 UTC) #1
Emily Fortuna
8 years, 4 months ago (2012-08-18 00:46:30 UTC) #2
lgtm, with suggestion

https://chromiumcodereview.appspot.com/10836319/diff/1/pkg/i18n/lib/date_form...
File pkg/i18n/lib/date_format_helpers.dart (right):

https://chromiumcodereview.appspot.com/10836319/diff/1/pkg/i18n/lib/date_form...
pkg/i18n/lib/date_format_helpers.dart:131: // but makes a moderate difference in
Javascript right now.
perhaps we could do something a little fancier like find the first non-digit
character using a regular expression, and parse that set of digit charaters
together, so we're not always going digit by digit.

Powered by Google App Engine
This is Rietveld 408576698