Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: chrome/browser/ui/extensions/application_launch.cc

Issue 10836301: Make apps with launch container type panel open as popups. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Synced Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/management/management_apitest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/extensions/application_launch.cc
diff --git a/chrome/browser/ui/extensions/application_launch.cc b/chrome/browser/ui/extensions/application_launch.cc
index 0920a03e1f9fca3b5cb3fa6f0f1d9ea2e406932e..d7acfa5f98a304df3676d132447b5b98fc7c0216 100644
--- a/chrome/browser/ui/extensions/application_launch.cc
+++ b/chrome/browser/ui/extensions/application_launch.cc
@@ -18,7 +18,6 @@
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/browser_window.h"
-#include "chrome/browser/ui/panels/panel_manager.h"
#include "chrome/browser/ui/tab_contents/tab_contents.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/web_applications/web_app.h"
@@ -31,11 +30,6 @@
#include "content/public/browser/web_contents_view.h"
#include "content/public/common/renderer_preferences.h"
-#if defined(USE_ASH)
-#include "ash/ash_switches.h"
-#include "chrome/browser/ui/views/ash/panel_view_aura.h"
-#endif
-
using content::WebContents;
using extensions::Extension;
using extensions::ExtensionPrefs;
@@ -69,11 +63,6 @@ GURL UrlForExtension(const Extension* extension,
return url;
}
-bool AllowPanels(const std::string& app_name) {
- return PanelManager::ShouldUsePanels(
- web_app::GetExtensionIdFromApplicationName(app_name));
-}
-
WebContents* OpenApplicationWindow(
Profile* profile,
const Extension* extension,
@@ -89,11 +78,6 @@ WebContents* OpenApplicationWindow(
web_app::GenerateApplicationNameFromURL(url);
Browser::Type type = Browser::TYPE_POPUP;
- if (extension &&
- container == extension_misc::LAUNCH_PANEL &&
- AllowPanels(app_name)) {
- type = Browser::TYPE_PANEL;
- }
gfx::Rect window_bounds;
if (extension) {
@@ -130,12 +114,6 @@ WebContents* OpenApplicationWindow(
WebContents* contents = tab_contents->web_contents();
contents->GetMutableRendererPrefs()->can_accept_load_drops = false;
contents->GetRenderViewHost()->SyncRendererPrefs();
- // TODO(stevenjb): Find the right centralized place to do this. Currently it
- // is only done for app tabs in normal browsers through SetExtensionAppById.
- if (extension && type == Browser::TYPE_PANEL) {
- tab_contents->extension_tab_helper()->
- SetExtensionAppIconById(extension->id());
- }
browser->window()->Show();
@@ -236,28 +214,6 @@ WebContents* OpenApplicationTab(Profile* profile,
return contents;
}
-WebContents* OpenApplicationPanel(
- Profile* profile,
- const Extension* extension,
- const GURL& url_input) {
- GURL url = UrlForExtension(extension, url_input);
- std::string app_name =
- web_app::GenerateApplicationNameFromExtensionId(extension->id());
- gfx::Rect panel_bounds;
- panel_bounds.set_width(extension->launch_width());
- panel_bounds.set_height(extension->launch_height());
-#if defined(USE_ASH)
- PanelViewAura* panel_view = new PanelViewAura(app_name);
- panel_view->Init(profile, url, panel_bounds);
- return panel_view->WebContents();
-#else
- Panel* panel = PanelManager::GetInstance()->CreatePanel(
- app_name, profile, url, panel_bounds.size());
- panel->Show();
- return panel->GetWebContents();
-#endif
-}
-
} // namespace
namespace application_launch {
« no previous file with comments | « chrome/browser/extensions/api/management/management_apitest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698