Issue 10836290: Prepare push to trunk. Now working on version 3.13.2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10836290: Prepare push to trunk. Now working on version 3.13.2. (Closed)

Created:
8 years, 4 months ago by Toon Verwaest

Modified:
8 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Prepare push to trunk. Now working on version 3.13.2. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=12322

Patch Set 1 #

Total comments: 3

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	ChangeLog	View		1 chunk	+14 lines, -0 lines	3 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 4 months ago (2012-08-16 15:38:51 UTC) #2

LGTM (with comments on the changelog).

https://chromiumcodereview.appspot.com/10836290/diff/1/ChangeLog
File ChangeLog (right):

https://chromiumcodereview.appspot.com/10836290/diff/1/ChangeLog#newcode4
ChangeLog:4: (Chromium issue 142088)
We didn't even mention the improvement itself in the last changelog ... let's
just drop it.

https://chromiumcodereview.appspot.com/10836290/diff/1/ChangeLog#newcode7
ChangeLog:7: (Chromium issue 140050)
That's only a check, not a fix for that issue. Let's also drop it.

https://chromiumcodereview.appspot.com/10836290/diff/1/ChangeLog#newcode9
ChangeLog:9: Fixed wrong indexing in global regexp.
I think we can also drop this one.

Expand Messages | Collapse Messages