Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 10836278: Add additional logging. (Closed)

Created:
8 years, 4 months ago by Albert Bodenhamer
Modified:
8 years, 4 months ago
Reviewers:
gene, gene1
CC:
chromium-reviews
Visibility:
Public.

Description

Add additional logging. Add additional logging and message to server for dealing with printers that a connector loses track of. BUG=142337 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_connector.cc View 3 chunks +17 lines, -4 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_consts.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_consts.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Albert Bodenhamer
8 years, 4 months ago (2012-08-16 01:02:34 UTC) #1
gene
lgtm
8 years, 4 months ago (2012-08-16 01:15:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/10836278/1
8 years, 4 months ago (2012-08-16 17:36:31 UTC) #3
Albert Bodenhamer
The more I think about this, the more I think zombie IS the correct name ...
8 years, 4 months ago (2012-08-16 17:36:36 UTC) #4
gene1
Sure. :) On Thu, Aug 16, 2012 at 10:36 AM, Albert Bodenhamer <abodenha@chromium.org>wrote: > The ...
8 years, 4 months ago (2012-08-16 17:49:20 UTC) #5
commit-bot: I haz the power
List of reviewers changed. gene@google.com did a drive-by without LGTM'ing!
8 years, 4 months ago (2012-08-16 21:10:11 UTC) #6
Albert Bodenhamer
Sigh. Gene can you lgtm from your @google.com account? CQ thinks your "Sure" was a ...
8 years, 4 months ago (2012-08-16 21:53:02 UTC) #7
gene1
lgtm On 2012/08/16 21:53:02, Albert Bodenhamer wrote: > Sigh. Gene can you lgtm from your ...
8 years, 4 months ago (2012-08-16 21:54:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/10836278/1
8 years, 4 months ago (2012-08-16 21:57:46 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 02:22:35 UTC) #10
Change committed as 152021

Powered by Google App Engine
This is Rietveld 408576698