Issue 10836274: gcapi/mac: Put master prefs in the right place

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10836274: gcapi/mac: Put master prefs in the right place (Closed)

Created:
8 years, 4 months ago by Nico

Modified:
8 years, 4 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, grt+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gcapi/mac: Put master prefs in the right place chrome/browser/master_prefs.mm reads the user master prefs file from ~/Application Support/Google/Chrome, not ~/AS/Google. Found by Mike Graboski! BUG=128462 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151768

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/installer/gcapi_mac/gcapi.mm	View		1 chunk	+2 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM https://chromiumcodereview.appspot.com/10836274/diff/1/chrome/installer/gcapi_mac/gcapi.mm File chrome/installer/gcapi_mac/gcapi.mm (right): https://chromiumcodereview.appspot.com/10836274/diff/1/chrome/installer/gcapi_mac/gcapi.mm#newcode1 chrome/installer/gcapi_mac/gcapi.mm:1: // Copyright (c) 2012 The Chromium Authors. All ...

8 years, 4 months ago (2012-08-15 22:20:06 UTC) #2

Nico

https://chromiumcodereview.appspot.com/10836274/diff/1/chrome/installer/gcapi_mac/gcapi.mm File chrome/installer/gcapi_mac/gcapi.mm (right): https://chromiumcodereview.appspot.com/10836274/diff/1/chrome/installer/gcapi_mac/gcapi.mm#newcode1 chrome/installer/gcapi_mac/gcapi.mm:1: // Copyright (c) 2012 The Chromium Authors. All rights ...

8 years, 4 months ago (2012-08-15 22:21:44 UTC) #3

LGTM

Expand Messages | Collapse Messages