Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 10836271: Removing kCheckDefaultBrowser pref modification after the user choses a (Closed)

Created:
8 years, 4 months ago by motek.
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Removing kCheckDefaultBrowser pref modification after the user choses a different default browser. This is a trivial change, but it will deal with both issues. Asking for review & owner's review at the same time since this is only 2 lines. R=sky BUG=140065, 141181 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151857

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chrome/browser/ui/startup/default_browser_prompt.cc View 1 chunk +0 lines, -3 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
motek.
8 years, 4 months ago (2012-08-15 19:43:20 UTC) #1
sky
https://chromiumcodereview.appspot.com/10836271/diff/1/chrome/browser/ui/startup/default_browser_prompt.cc File chrome/browser/ui/startup/default_browser_prompt.cc (left): https://chromiumcodereview.appspot.com/10836271/diff/1/chrome/browser/ui/startup/default_browser_prompt.cc#oldcode47 chrome/browser/ui/startup/default_browser_prompt.cc:47: // User clicked "Don't ask me again", remember that. ...
8 years, 4 months ago (2012-08-15 21:09:28 UTC) #2
motek.
https://chromiumcodereview.appspot.com/10836271/diff/1/chrome/browser/ui/startup/default_browser_prompt.cc File chrome/browser/ui/startup/default_browser_prompt.cc (left): https://chromiumcodereview.appspot.com/10836271/diff/1/chrome/browser/ui/startup/default_browser_prompt.cc#oldcode47 chrome/browser/ui/startup/default_browser_prompt.cc:47: // User clicked "Don't ask me again", remember that. ...
8 years, 4 months ago (2012-08-15 21:19:36 UTC) #3
sky
LGTM
8 years, 4 months ago (2012-08-16 00:12:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/motek@chromium.org/10836271/1
8 years, 4 months ago (2012-08-16 00:46:24 UTC) #5
commit-bot: I haz the power
Try job failure for 10836271-1 (previous was lost) (retry) on linux_rel for step "interactive_ui_tests". It's ...
8 years, 4 months ago (2012-08-16 02:37:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/motek@chromium.org/10836271/1
8 years, 4 months ago (2012-08-16 02:40:14 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-16 06:53:04 UTC) #8
Change committed as 151857

Powered by Google App Engine
This is Rietveld 408576698