chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm - Issue 10836270: Do not close the omnibox popup on mouseDown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

Issue 10836270: Do not close the omnibox popup on mouseDown. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Remove -mouseDown from editor. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

index 748d4e2bc6fc5f190c61e8aac41a7e4c4200e49b..deb9b2d6ef362d65c0bd8b97d6b8273cd378325a 100644

--- a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

+++ b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

@@ -468,15 +468,6 @@ BOOL ThePasteboardIsTooDamnBig() {

textChangedByKeyEvents_ = NO;

}

-- (void)mouseDown:(NSEvent*)theEvent {

- // Close the popup before processing the event.

- AutocompleteTextFieldObserver* observer = [self observer];

- if (observer)

- observer->ClosePopup();

- [super mouseDown:theEvent];

- (BOOL)validateMenuItem:(NSMenuItem*)item {

if ([item action] == @selector(copyToFindPboard:))

return [self selectedRange].length > 0;

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm ('k') | no next file » | no next file with comments »