dart2dart Preproces placeholders instead of renaming them lazily,

lib/compiler/implementation/dart_backend/placeholder.dart

Index: lib/compiler/implementation/dart_backend/placeholder.dart
diff --git a/lib/compiler/implementation/dart_backend/placeholder.dart b/lib/compiler/implementation/dart_backend/placeholder.dart
index 0c847170c978bbb46a800806a9535878e1da3324..d4247535b4e4a762efd5144dd782848fb9f13118 100644
--- a/lib/compiler/implementation/dart_backend/placeholder.dart
+++ b/lib/compiler/implementation/dart_backend/placeholder.dart
@@ -2,46 +2,34 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-class Placeholder {
-  const Placeholder();
-  abstract String rename(ConflictingRenamer renamer);
-}
+interface Placeholder {}

[Anton Muhin, 2012/08/15 12:19:30]

no interfaces, please.  Esp. empty ones.

[Roman, 2012/08/15 12:43:21]

Why not?

 
-class NullPlaceholder extends Placeholder {
-  String rename(ConflictingRenamer renamer) => '';
+class NullPlaceholder implements Placeholder {
   String toString() => 'null_placeholder[]';
 }
 
-class PrivatePlaceholder extends Placeholder {
+class PrivatePlaceholder implements Placeholder {
   final LibraryElement library;
   final Identifier node;
   PrivatePlaceholder(this.library, this.node);
-  String rename(ConflictingRenamer renamer) =>
-      renamer.renamePrivateIdentifier(library, node.source.slowToString());
   String toString() => 'private_placeholder[node($node), $library]';
 }
 
-class ElementPlaceholder extends Placeholder {
+class ElementPlaceholder implements Placeholder {
   final Element element;
   ElementPlaceholder(this.element);
-  String rename(ConflictingRenamer renamer) => renamer.renameElement(element);
   String toString() => 'element_placeholder[$element]';
 }
 
-class UnresolvedPlaceholder extends Placeholder {
+class UnresolvedPlaceholder implements Placeholder {
   const UnresolvedPlaceholder();
-  String rename(ConflictingRenamer renamer) =>
-      renamer.generateUniqueName('unresolved');
   String toString() => 'unresolved_placeholder';
 }
 
-class LocalPlaceholder extends Placeholder {
+class LocalPlaceholder implements Placeholder {
   final FunctionElement scope;
   final String identifier;
   LocalPlaceholder(this.scope, this.identifier);
-
-  String rename(ConflictingRenamer renamer) =>
-      renamer.renameLocalIdentifier(scope, identifier);
   String toString() =>
       'local_placeholder[scope($scope), id($identifier)]';
 }