Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 10836258: Improved constructor inlining unit tests. (Closed)

Created:
8 years, 4 months ago by Sven Panne
Modified:
8 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Improved constructor inlining unit tests. Currently we inline functions with different contexts only on ia32, so we have to move the helper functions for the various contexts to the top level. Further more, "new Object()" seems to prevent inlining, too, so we us a simple object literal. Although things get consistently inlined now, something strange seems to happen in test/effect contexts: The DEOPT output seems to contain too few frames, and we don't get any DEOPT ouput after the first time for those contexts. This has to be investigated... TBR=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -29 lines) Patch
M test/mjsunit/compiler/inline-construct.js View 2 chunks +33 lines, -29 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698