Prefix match CHROMEOS_RELEASE_BOARD for checking chromebox.

Prefix match CHROMEOS_RELEASE_BOARD for checking chromebox.

It used to conatin only "stumpy", but recently official image contains
some suffix, and looks like "stumpy-signed-mp-v2keys". That change caused
regression, and this should fix it.

BUG=chromium:126732
TEST=Open some tabs on stumpy and sync, then on the other machine you should see "Chromebox" instead of "Chromebook" in "ohter devices" menu in new tab page.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151839

[kochi, 2012-08-15 08:12:07]

Hi Nicolas,

Could you review this?
Thanks,

[kochi, 2012-08-15 14:18:15]

On 2012/08/15 08:12:07, Takayoshi Kochi wrote:
> Hi Nicolas,
> 
> Could you review this?
> Thanks,

FYI, I intend to merge this to M22 as well.

[Nicolas Zea, 2012-08-15 20:53:04]

lgtm

http://codereview.chromium.org/10836257/diff/1/sync/util/get_session_name.cc
File sync/util/get_session_name.cc (right):

http://codereview.chromium.org/10836257/diff/1/sync/util/get_session_name.cc#...
sync/util/get_session_name.cc:44: session_name = board.find("stumpy") == 0 ?
"Chromebox" : "Chromebook";
Nit: do we want to enforce that "stumpy" is always as the beginning? If so, I
think doing something like booard.substr(0, 6) == "stumpy" might be more clear.

[kochi, 2012-08-16 01:22:06]

Thanks for the review!

https://chromiumcodereview.appspot.com/10836257/diff/1/sync/util/get_session_...
File sync/util/get_session_name.cc (right):

https://chromiumcodereview.appspot.com/10836257/diff/1/sync/util/get_session_...
sync/util/get_session_name.cc:44: session_name = board.find("stumpy") == 0 ?
"Chromebox" : "Chromebook";
Done.

I don't have strong preference to either, but substr()
sounds more efficient for non-matching case.

On 2012/08/15 20:53:04, nzea wrote:
> Nit: do we want to enforce that "stumpy" is always as the beginning? If so, I
> think doing something like booard.substr(0, 6) == "stumpy" might be more
clear.

[commit-bot: I haz the power, 2012-08-16 01:28:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/10836257/5002

[commit-bot: I haz the power, 2012-08-16 03:16:13]

Change committed as 151839