Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 10836250: Merge 125577 - [chromium] race between CCLayerTreeHostImpl::releaseContentsTextures and CCThreadPro… (Closed)

Created:
8 years, 4 months ago by piman
Modified:
8 years, 4 months ago
Reviewers:
piman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1229/
Visibility:
Public.

Description

Merge 125577 - [chromium] race between CCLayerTreeHostImpl::releaseContentsTextures and CCThreadProxy::beginFrameCompleteOnImplThread https://bugs.webkit.org/show_bug.cgi?id=93684 Reviewed by James Robinson. This keeps track of whether we're between the beginFrame post and the commit when releaseContentsTextures comes, and if that is the case, we prune the texture uploads, keep the "textures purged" flag on and kick a new commit. Added CCLayerTreeHostTestEvictTextures test. * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl): (WebCore::CCLayerTreeHostImpl::beginFramePosted): (WebCore): (WebCore::CCLayerTreeHostImpl::commitComplete): (WebCore::CCLayerTreeHostImpl::canDraw): (WebCore::CCLayerTreeHostImpl::releaseContentsTextures): * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: (CCLayerTreeHostImpl): (WebCore::CCLayerTreeHostImpl::contentsTexturesPurged): (WebCore::CCLayerTreeHostImpl::contentsTexturesWerePurgedSinceLastBeginFrame): * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: (WebCore::CCSingleThreadProxy::stop): (WebCore::CCSingleThreadProxy::commitAndComposite): * platform/graphics/chromium/cc/CCTextureUpdateController.h: (CCTextureUpdateController): * platform/graphics/chromium/cc/CCTextureUpdateQueue.cpp: (WebCore::CCTextureUpdateQueue::clearUploads): (WebCore): * platform/graphics/chromium/cc/CCTextureUpdateQueue.h: (CCTextureUpdateQueue): * platform/graphics/chromium/cc/CCThreadProxy.cpp: (WebCore::CCThreadProxy::scheduledActionBeginFrame): (WebCore::CCThreadProxy::beginFrameCompleteOnImplThread): (WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread): TBR=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125699

Patch Set 1 #

Messages

Total messages: 1 (0 generated)
piman
8 years, 4 months ago (2012-08-14 20:46:46 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698