Issue 10836242: Made result_filefaceid output optional in FontConfigIPC::Match. There are cases when we are only in…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10836242: Made result_filefaceid output optional in FontConfigIPC::Match. There are cases when we are only in… (Closed)

Created:
8 years, 4 months ago by alokp

Modified:
8 years, 4 months ago

Reviewers:
brettw

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, reed1

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Made result_filefaceid output optional in FontConfigIPC::Match. There are cases when we are only interested in result_family. BUG=142421 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152247

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	content/common/font_config_ipc_linux.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	skia/ext/SkFontHost_fontconfig_impl.h	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 7 (0 generated)

chudy

On 2012/08/14 17:36:31, Alok Priyadarshi wrote: fixes bug 142421 when patch applied locally, just need ...

8 years, 4 months ago (2012-08-14 17:41:08 UTC) #2

brettw

If this is getting called with NULL, we should be sure to update the FontConfigInterface ...

8 years, 4 months ago (2012-08-16 05:11:04 UTC) #3

alokp

On 2012/08/16 05:11:04, brettw wrote: > If this is getting called with NULL, we should ...

8 years, 4 months ago (2012-08-17 16:40:06 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/10836242/7001

8 years, 4 months ago (2012-08-18 04:38:57 UTC) #6

Change committed as 152247