Issue 10836235: Check overrides.

Issue 10836235: Check overrides. (Closed)

Created:
8 years, 4 months ago by ahe

Modified:
8 years, 4 months ago

Reviewers:
Lasse Reichstein Nielsen, karlklose

CC:
reviews_dartlang.org, kasperl, Johnni Winther

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Check overrides. Committed: https://code.google.com/p/dart/source/detail?r=10677

Patch Set 2 : Address review comments #

Patch Set 3 : Rebased #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -60 lines)			Patch
M	dart/lib/compiler/implementation/closure.dart	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	dart/lib/compiler/implementation/elements/elements.dart	View	1 2	2 chunks	+22 lines, -0 lines	0 comments	Download
M	dart/lib/compiler/implementation/enqueue.dart	View	1 2	1 chunk	+14 lines, -4 lines	0 comments	Download
M	dart/tests/co19/co19-leg.status	View	1 2	2 chunks	+5 lines, -38 lines	0 comments	Download
M	dart/tests/language/language_dart2js.status	View	1 2	1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://chromiumcodereview.appspot.com/10836235/diff/1/dart/lib/compiler/implementation/elements/elements.dart File dart/lib/compiler/implementation/elements/elements.dart (right): https://chromiumcodereview.appspot.com/10836235/diff/1/dart/lib/compiler/implementation/elements/elements.dart#newcode1094 dart/lib/compiler/implementation/elements/elements.dart:1094: if (memberName.isPrivate() && fromLibrary !== e.getLibrary()) continue; You ...

8 years, 4 months ago (2012-08-14 11:06:51 UTC) #2

ahe

8 years, 4 months ago (2012-08-14 18:20:34 UTC) #3

Thank you, Karl!

Cheers,
Peter

https://chromiumcodereview.appspot.com/10836235/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/10836235/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/elements/elements.dart:1094: if
(memberName.isPrivate() && fromLibrary !== e.getLibrary()) continue;
On 2012/08/14 11:06:51, karlklose wrote:
> You could store the result of memberName.isPrivate() in a local outside the
> loop.

Done.

https://chromiumcodereview.appspot.com/10836235/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/elements/elements.dart:1099: }
On 2012/08/14 11:06:51, karlklose wrote:
> I would prefer an explicit 'return null' here.

Done.

https://chromiumcodereview.appspot.com/10836235/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/enqueue.dart (right):

https://chromiumcodereview.appspot.com/10836235/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/enqueue.dart:217: cls.ensureResolved(compiler);
// So allSupertypesAndSelf works.
On 2012/08/14 11:06:51, karlklose wrote:
> How about something like 'Compute set of all supertypes.'?

Done.

Expand Messages | Collapse Messages