Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: chrome/browser/ui/pdf/pdf_browsertest.cc

Issue 10836232: Disable PDFBrowserTest.Basic on Mac, as it's consistently failing on Mac Chrome release builder (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/file_util.h" 5 #include "base/file_util.h"
6 #include "base/path_service.h" 6 #include "base/path_service.h"
7 #include "base/string_number_conversions.h" 7 #include "base/string_number_conversions.h"
8 #include "base/string_util.h" 8 #include "base/string_util.h"
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 FilePath snapshot_filename_; 193 FilePath snapshot_filename_;
194 // How many times we've seen chrome::LOAD_STOP. 194 // How many times we've seen chrome::LOAD_STOP.
195 int load_stop_notification_count_; 195 int load_stop_notification_count_;
196 196
197 scoped_ptr<net::TestServer> pdf_test_server_; 197 scoped_ptr<net::TestServer> pdf_test_server_;
198 }; 198 };
199 199
200 #if defined(OS_CHROMEOS) 200 #if defined(OS_CHROMEOS)
201 // TODO(sanjeevr): http://crbug.com/79837 201 // TODO(sanjeevr): http://crbug.com/79837
202 #define MAYBE_Basic DISABLED_Basic 202 #define MAYBE_Basic DISABLED_Basic
203 #elif defined(OS_MACOSX)
204 // Fails on release builder for Mac: http://crbug.com/142531
205 #define MAYBE_Basic DISABLED_Basic
203 #else 206 #else
204 #define MAYBE_Basic Basic 207 #define MAYBE_Basic Basic
205 #endif 208 #endif
206 // Tests basic PDF rendering. This can be broken depending on bad merges with 209 // Tests basic PDF rendering. This can be broken depending on bad merges with
207 // the vendor, so it's important that we have basic sanity checking. 210 // the vendor, so it's important that we have basic sanity checking.
208 IN_PROC_BROWSER_TEST_F(PDFBrowserTest, MAYBE_Basic) { 211 IN_PROC_BROWSER_TEST_F(PDFBrowserTest, MAYBE_Basic) {
209 ASSERT_NO_FATAL_FAILURE(Load()); 212 ASSERT_NO_FATAL_FAILURE(Load());
210 ASSERT_NO_FATAL_FAILURE(WaitForResponse()); 213 ASSERT_NO_FATAL_FAILURE(WaitForResponse());
211 // OS X uses CoreText, and FreeType renders slightly different on Linux and 214 // OS X uses CoreText, and FreeType renders slightly different on Linux and
212 // Win. 215 // Win.
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 chrome::GetActiveWebContents(browser())->GetRenderViewHost(), 357 chrome::GetActiveWebContents(browser())->GetRenderViewHost(),
355 std::wstring(), 358 std::wstring(),
356 L"reloadPDF();")); 359 L"reloadPDF();"));
357 observer.Wait(); 360 observer.Wait();
358 361
359 ASSERT_EQ("success", 362 ASSERT_EQ("success",
360 chrome::GetActiveWebContents(browser())->GetURL().query()); 363 chrome::GetActiveWebContents(browser())->GetURL().query());
361 } 364 }
362 365
363 } // namespace 366 } // namespace
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698