Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 10836226: Change default host resolution to 1280x800. (Closed)

Created:
8 years, 4 months ago by Sergey Ulanov
Modified:
8 years, 4 months ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, pam+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Change default host resolution to 1280x800. 1280x800 is resolution of chromebook screens. For clients with higher resolution 1280x800 is still better because of most modern screens have 16:10 aspect ratio. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151459

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/tools/me2me_virtual_host.py View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 9 (0 generated)
Sergey Ulanov
8 years, 4 months ago (2012-08-13 23:38:53 UTC) #1
Wez
http://codereview.chromium.org/10836226/diff/1/remoting/tools/me2me_virtual_host.py File remoting/tools/me2me_virtual_host.py (right): http://codereview.chromium.org/10836226/diff/1/remoting/tools/me2me_virtual_host.py#newcode641 remoting/tools/me2me_virtual_host.py:641: DEFAULT_SIZE = "1280x800" Is 800px high enough for all ...
8 years, 4 months ago (2012-08-13 23:41:57 UTC) #2
Lambros
On 2012/08/13 23:41:57, Wez wrote: > http://codereview.chromium.org/10836226/diff/1/remoting/tools/me2me_virtual_host.py > File remoting/tools/me2me_virtual_host.py (right): > > http://codereview.chromium.org/10836226/diff/1/remoting/tools/me2me_virtual_host.py#newcode641 > ...
8 years, 4 months ago (2012-08-14 00:32:37 UTC) #3
Sergey Ulanov
http://codereview.chromium.org/10836226/diff/1/remoting/tools/me2me_virtual_host.py File remoting/tools/me2me_virtual_host.py (right): http://codereview.chromium.org/10836226/diff/1/remoting/tools/me2me_virtual_host.py#newcode641 remoting/tools/me2me_virtual_host.py:641: DEFAULT_SIZE = "1280x800" On 2012/08/13 23:41:57, Wez wrote: > ...
8 years, 4 months ago (2012-08-14 00:58:51 UTC) #4
Wez
lgtm
8 years, 4 months ago (2012-08-14 01:11:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10836226/1
8 years, 4 months ago (2012-08-14 01:45:20 UTC) #6
commit-bot: I haz the power
Try job failure for 10836226-1 (retry) on linux_chromeos for steps "browser_tests, content_browsertests". It's a second ...
8 years, 4 months ago (2012-08-14 05:56:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10836226/1
8 years, 4 months ago (2012-08-14 08:47:56 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-14 11:13:26 UTC) #9
Change committed as 151459

Powered by Google App Engine
This is Rietveld 408576698