Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 10836224: [Chromoting] Call SendSAS() directly from the host. (Closed)

Created:
7 years, 9 months ago by alexeypa (please no reviews)
Modified:
7 years, 9 months ago
Reviewers:
simonmorris
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

[Chromoting] Call SendSAS() directly from the host. In order to call SendSAS() successfully the calling process's binary has to: - be signed. - be installed under %ProgramFiles% or %SystemRoot%\system32. - specify uiAccess='true' in the manifest. - run under SYSTEM or the currently logged-on user. All of those requirements are met now, so SendSAS() can be called directly. BUG=135217 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152191

Patch Set 1 #

Patch Set 2 : SensSAS() is called from an app now. #

Total comments: 1

Patch Set 3 : rebased and made it work. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -104 lines) Patch
M remoting/host/chromoting_messages.h View 1 chunk +0 lines, -7 lines 0 comments Download
M remoting/host/sas_injector_win.cc View 1 2 6 chunks +53 lines, -9 lines 0 comments Download
M remoting/host/session_event_executor_win.h View 1 2 3 chunks +4 lines, -7 lines 0 comments Download
M remoting/host/session_event_executor_win.cc View 5 chunks +4 lines, -50 lines 0 comments Download
M remoting/host/win/wts_session_process_launcher.h View 1 2 3 chunks +0 lines, -7 lines 0 comments Download
M remoting/host/win/wts_session_process_launcher.cc View 1 2 3 chunks +1 line, -22 lines 0 comments Download
M remoting/remoting.gyp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
alexeypa (please no reviews)
PTAL.
7 years, 9 months ago (2012-08-13 23:34:50 UTC) #1
simonmorris
lgtm with optional suggestion. http://codereview.chromium.org/10836224/diff/2001/remoting/host/sas_injector_win.cc File remoting/host/sas_injector_win.cc (right): http://codereview.chromium.org/10836224/diff/2001/remoting/host/sas_injector_win.cc#newcode173 remoting/host/sas_injector_win.cc:173: // if the policy does ...
7 years, 9 months ago (2012-08-14 17:29:59 UTC) #2
alexeypa (please no reviews)
On 2012/08/14 17:29:59, simonmorris wrote: > lgtm with optional suggestion. > > http://codereview.chromium.org/10836224/diff/2001/remoting/host/sas_injector_win.cc > File ...
7 years, 9 months ago (2012-08-14 18:26:08 UTC) #3
alexeypa (please no reviews)
> Well, I cannot get this CL to work. The host now complies with all ...
7 years, 9 months ago (2012-08-17 21:21:13 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2012-08-17 21:48:54 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698